Skip evm antehandler on non-secp signatures #1606
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
EVM antehandler is failing for legacy sr25519 signatures. Specifically,
pk, err := btcec.ParsePubKey(acc.GetPubKey().Bytes(), btcec.S256())
fails when the len is unexpected, which is generally the case for non-secp256k1 signatures. Because this antehandler is just associating addresses, we can silently ignoreTesting performed to validate your change
Deployed and verified errors are gone: