Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip evm antehandler on non-secp signatures #1606

Merged
merged 6 commits into from
Apr 29, 2024
Merged

Conversation

philipsu522
Copy link
Contributor

Describe your changes and provide context

EVM antehandler is failing for legacy sr25519 signatures. Specifically, pk, err := btcec.ParsePubKey(acc.GetPubKey().Bytes(), btcec.S256()) fails when the len is unexpected, which is generally the case for non-secp256k1 signatures. Because this antehandler is just associating addresses, we can silently ignore

Testing performed to validate your change

Deployed and verified errors are gone:
image

@philipsu522 philipsu522 changed the title Seid evm ante fail Skip evm antehandler on non-secp signatures Apr 29, 2024
@philipsu522 philipsu522 requested a review from udpatil April 29, 2024 16:59
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.03%. Comparing base (28c621d) to head (419b947).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1606      +/-   ##
==========================================
- Coverage   61.11%   61.03%   -0.08%     
==========================================
  Files         365      365              
  Lines       26104    26104              
==========================================
- Hits        15953    15933      -20     
- Misses       9148     9167      +19     
- Partials     1003     1004       +1     
Files Coverage Δ
x/evm/ante/preprocess.go 77.69% <100.00%> (ø)

... and 3 files with indirect coverage changes

@philipsu522 philipsu522 enabled auto-merge (squash) April 29, 2024 17:32
@philipsu522 philipsu522 merged commit 9df725e into main Apr 29, 2024
47 checks passed
@philipsu522 philipsu522 deleted the seid-evm-ante-fail branch April 29, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants