-
Notifications
You must be signed in to change notification settings - Fork 422
bunch of updates #139
base: master
Are you sure you want to change the base?
bunch of updates #139
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,26 @@ | ||
--- | ||
# Latest xenial 16.04 LTS amd64 hvm:ebs-ssd Releases | ||
# us-gov-west-1 20170619.1 ami-939412f2 | ||
# us-east-2 20170619.1 ami-8b92b4ee | ||
# sa-east-1 20170619.1 ami-34afc458 | ||
# eu-central-1 20170619.1 ami-1c45e273 | ||
# us-west-1 20170619.1 ami-73f7da13 | ||
# us-west-2 20170619.1 ami-835b4efa | ||
# ap-northeast-2 20170619.1 ami-94d20dfa | ||
# ca-central-1 20170619.1 ami-7ed56a1a | ||
# eu-west-2 20170619.1 ami-cc7066a8 | ||
# ap-southeast-1 20170619.1 ami-2378f540 | ||
# eu-west-1 20170619.1 ami-6d48500b | ||
# ap-southeast-2 20170619.1 ami-e94e5e8a | ||
# ap-northeast-1 20170619.1 ami-785c491f | ||
# us-east-1 20170619.1 ami-d15a75c7 | ||
# ap-south-1 20170619.1 ami-49e59a26 | ||
# cn-north-1 20170303 ami-a163b4cc | ||
|
||
|
||
# https://www.packer.io/docs/builders/amazon-ebs.html | ||
ami: | ||
source_ami: ami-e6d5d2f1 | ||
source_ami: ami-d15a75c7 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this the ID of an official image? Do you mind giving a link to it so we can verify how it was built? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ofc. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If your making updates to leverage handy new terraform features, why not throw in the AMI data resource? https://www.terraform.io/docs/providers/aws/d/ami.html There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe in the next one? Although Im wary of unrepeatable builds. You could.argue that I have sent the ECS agent to the latest docker tag. Your call. EDIT: @gjohnson did you mean at the ecs-cluster module level aiming for "^myami-\d{3}" of the self account ? |
||
region: us-east-1 | ||
instance_type: c4.2xlarge | ||
ssh_username: ubuntu | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
Package: * | ||
Pin: release o=Docker | ||
Pin-Priority: 900 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,7 @@ ExecStartPre=/bin/mkdir -p /var/lib/ecs/data | |
ExecStartPre=/bin/mkdir -p /var/log/ecs | ||
ExecStartPre=-/usr/bin/docker kill ecs-agent | ||
ExecStartPre=-/usr/bin/docker rm ecs-agent | ||
ExecStartPre=-/usr/bin/docker pull amazon/amazon-ecs-agent:v1.14.1 | ||
ExecStartPre=-/usr/bin/docker pull amazon/amazon-ecs-agent:latest | ||
ExecStart=/usr/bin/docker run \ | ||
--name=ecs-agent \ | ||
--restart=on-failure:10 \ | ||
|
@@ -27,7 +27,7 @@ ExecStart=/usr/bin/docker run \ | |
--publish=127.0.0.1:51679:51679 \ | ||
--env-file=/etc/ecs/ecs.config \ | ||
--env=ECS_CLUSTER=${SERVER_GROUP} \ | ||
amazon/amazon-ecs-agent:v1.14.1 | ||
amazon/amazon-ecs-agent:latest | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Dont know if this is a great idea. It happened to me twice that they introduce a critical bug in the latest version and screwed up all my cluster. Personally I would prefer to have that stuck to a fixed version |
||
ExecStop=-/usr/bin/docker stop ecs-agent | ||
|
||
[Install] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind running
terraform fmt
, I think the formatting is incorrect here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please run a final check beforehand, just to make sure.