bunch of updates #139

Brzhk · 2017-07-24T12:17:55Z

so far:

couple of typos fixed
packer images bumped to the latest xenial release
terraform syntax changes
amazon/amazon-ecs-agent docker image uses the latest tag now
segment/ecs-logs from 0.1.1 to 0.1.5
ixgbevf from 3.1.2 to 3.4.3
terraform 0.7.2 to 0.9.11
packer 0.10.1 to 1.0.3
dumb-init from 1.1.3 to 1.2.0
some bash syntax best practices here or there.
the image kernel is not bumped anymore
removed now unnecessary dependency to linux-image-extra
patched ixgbevf compilation for x.x.x-255+ aws kernel images.
adds necessary lib for EFS usage (nfs-common)
adds some tools (curl, unzip, jq)

- latest xenial ubuntu release base - amazon/amazon-ecs-agent docker image uses the latest tag now - segment/ecs-logs from 0.1.1 to 0.1.5 - ixgbevf from 3.1.2 to 3.4.3 - terraform 0.7.2 to 0.9.11 - packer 0.10.1 to 1.0.3 - dumb-init from 1.1.3 to 1.2.0 - some bash syntax best practices here or there.

achille-roussel

Those are great changes, thanks a lot for your contributions!

I left a couple of comments inline, once addressed I'll be happy to merge this.

achille-roussel · 2017-07-24T20:00:04Z

defaults/main.tf

@@ -23,6 +23,7 @@ variable "cidr" {
 }

 variable "default_ecs_ami" {
+  type = "map"


Do you mind running terraform fmt, I think the formatting is incorrect here.

Also please run a final check beforehand, just to make sure.

achille-roussel · 2017-07-24T20:02:28Z

packer/base/packer.yml

 # https://www.packer.io/docs/builders/amazon-ebs.html
 ami:
-  source_ami: ami-e6d5d2f1
+  source_ami: ami-d15a75c7


Is this the ID of an official image? Do you mind giving a link to it so we can verify how it was built?

ofc.
you can find it here: https://cloud-images.ubuntu.com/locator/ec2/
also:
https://console.aws.amazon.com/ec2/v2/home?region=us-east-1#Images:visibility=public-images;search=ami-d15a75c7;sort=desc:name
same 099720109477 origin AWS account id.

If your making updates to leverage handy new terraform features, why not throw in the AMI data resource? https://www.terraform.io/docs/providers/aws/d/ami.html

Maybe in the next one? Although Im wary of unrepeatable builds. You could.argue that I have sent the ECS agent to the latest docker tag. Your call.

EDIT: @gjohnson did you mean at the ecs-cluster module level aiming for "^myami-\d{3}" of the self account ?

Brzhk · 2017-07-27T16:53:12Z

Sorry for bothering you @achille-roussel,
Has anyone looked into the DNS/DHCP/network configuration of the containers and/or host instances to ease up service discovery? I had some troubles in my first experiments with the stack, I'll soon have to look into this.

Is there a gitter/slack/IRC room we can discuss the stack so I can avoid hijacking the pull requests?

raja · 2017-08-15T20:46:42Z

Can this be merged?

martinkoch-geniebelt · 2017-09-08T18:19:56Z

Would be really nice if this could be merged :)

raja · 2017-09-08T18:40:19Z

I assume this repository has largely been abandoned and also ecs has changed significantly in the last year. I've used Segment's stack as guide and built a new stack module from scratch with the following key differences:

The container instances use Amazon ECS Optimized AMIs as base images (http://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-optimized_AMI.html)
The load balancer is changed from classic ELB to ALB (https://aws.amazon.com/elasticloadbalancing/)
Service scaling rules in addition to container instance scaling rules

If it is of interest to anyone, I'd be happy to publish it publicly.

martinkoch-geniebelt · 2017-09-08T18:58:28Z

@raja That would be really cool, thanks. In my local version, I have also created a web-service-alb, so we can compare notes on that one :)

jalessio · 2017-09-09T16:29:59Z

@raja and @martinkoch-geniebelt I've come to the similar conclusion that I should just use this repo as a template (which is a great start!) and modify to suit my own needs, but it would still be great to keep "the template" up to date somewhere. Please publish your fork if you're able to.

@raja and @martinkoch-geniebelt -- @slajax also has added ALB support in PR #134

pikeas · 2017-12-14T22:07:43Z

Is there a reason this hasn't been merged?

kc-dot-io · 2017-12-15T03:33:20Z

Most large PRs don’t end up merging here because doing so would impact all the downstream environments the next time a source is pulled. The approach it seems many of us are using is to maintain a fork that you can point all your sources to and just PR to this repo to share with others - If they want the change they can add your fork as a remote and diff / patch as needed. We’re maintaining our fork actively and have rolled out ALB support on internal services as well for example. Anyone who wants this change is welcome to it but ultimately it would be risky for the segment team to merge it here. It would require a lot of community engagement to do these changes right since terraform doesn’t yet have a robust way to deal with semantic versioning of external modules - just refs, which is insufficient for managing the roll out of breaking changes in a stable way. No one wants downtime because of upstream infra changes. Tread carefully.

pikeas · 2017-12-15T07:49:47Z

@slajax Is your fork public?

kc-dot-io · 2017-12-15T08:21:55Z

Yes. See open pull requests.

egarbi · 2017-12-29T12:41:22Z

packer/ecs/root/etc/systemd/system/ecs-agent.service

@@ -27,7 +27,7 @@ ExecStart=/usr/bin/docker run \
    --publish=127.0.0.1:51679:51679 \
    --env-file=/etc/ecs/ecs.config \
    --env=ECS_CLUSTER=${SERVER_GROUP} \
-    amazon/amazon-ecs-agent:v1.14.1
+    amazon/amazon-ecs-agent:latest


Dont know if this is a great idea. It happened to me twice that they introduce a critical bug in the latest version and screwed up all my cluster. Personally I would prefer to have that stuck to a fixed version

Brzhk added 3 commits July 24, 2017 13:56

typo fixes

867b3fd

terraform syntax changes

91a72ff

achille-roussel reviewed Jul 24, 2017

View reviewed changes

some more typo fixes and fmt.

88fa348

Brzhk mentioned this pull request Jul 27, 2017

ECS agent is outdated #137

Open

raja mentioned this pull request Aug 15, 2017

Outdated base ubuntu ami image + outdated ecs agent #140

Open

raja approved these changes Aug 15, 2017

View reviewed changes

egarbi reviewed Dec 29, 2017

View reviewed changes

webyneter mentioned this pull request Sep 25, 2018

bunch of updates webyneter/stack#9

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bunch of updates #139

bunch of updates #139

Brzhk commented Jul 24, 2017 •

edited

Loading

achille-roussel left a comment

achille-roussel Jul 24, 2017

Brzhk Jul 25, 2017

Brzhk Jul 25, 2017

achille-roussel Jul 24, 2017

Brzhk Jul 25, 2017

gjohnson Jul 31, 2017

Brzhk Aug 4, 2017 •

edited

Loading

Brzhk commented Jul 27, 2017

raja commented Aug 15, 2017

martinkoch-geniebelt commented Sep 8, 2017

raja commented Sep 8, 2017

martinkoch-geniebelt commented Sep 8, 2017

jalessio commented Sep 9, 2017

pikeas commented Dec 14, 2017

kc-dot-io commented Dec 15, 2017 •

edited

Loading

pikeas commented Dec 15, 2017

kc-dot-io commented Dec 15, 2017

egarbi Dec 29, 2017

bunch of updates #139

Are you sure you want to change the base?

bunch of updates #139

Conversation

Brzhk commented Jul 24, 2017 • edited Loading

achille-roussel left a comment

Choose a reason for hiding this comment

achille-roussel Jul 24, 2017

Choose a reason for hiding this comment

Brzhk Jul 25, 2017

Choose a reason for hiding this comment

Brzhk Jul 25, 2017

Choose a reason for hiding this comment

achille-roussel Jul 24, 2017

Choose a reason for hiding this comment

Brzhk Jul 25, 2017

Choose a reason for hiding this comment

gjohnson Jul 31, 2017

Choose a reason for hiding this comment

Brzhk Aug 4, 2017 • edited Loading

Choose a reason for hiding this comment

Brzhk commented Jul 27, 2017

raja commented Aug 15, 2017

martinkoch-geniebelt commented Sep 8, 2017

raja commented Sep 8, 2017

martinkoch-geniebelt commented Sep 8, 2017

jalessio commented Sep 9, 2017

pikeas commented Dec 14, 2017

kc-dot-io commented Dec 15, 2017 • edited Loading

pikeas commented Dec 15, 2017

kc-dot-io commented Dec 15, 2017

egarbi Dec 29, 2017

Choose a reason for hiding this comment

Brzhk commented Jul 24, 2017 •

edited

Loading

Brzhk Aug 4, 2017 •

edited

Loading

kc-dot-io commented Dec 15, 2017 •

edited

Loading