Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runtime errors on signals, allow text/plain in response #1177

Merged
merged 6 commits into from
Oct 31, 2024

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Oct 30, 2024

  • Fix runtime errors for submit
  • Add better form submit data
  • Loosen content-type to parse text/plain
  • Tweak disallow list
  • Add labels

Copy link

changeset-bot bot commented Oct 30, 2024

🦋 Changeset detected

Latest commit: 178bfd5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@segment/analytics-signals Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@silesky silesky requested a review from danieljackins October 30, 2024 21:12
@silesky silesky changed the title Fix runtime errors on signals Fix runtime errors on signals, allow plain/text in response Oct 30, 2024
@silesky silesky force-pushed the fix-runtime-errors-on-signals branch from bb2af15 to 1275d7c Compare October 30, 2024 21:42
@silesky silesky requested a review from MichaelGHSeg October 30, 2024 21:47
@silesky silesky merged commit 11a943e into master Oct 31, 2024
7 checks passed
@silesky silesky deleted the fix-runtime-errors-on-signals branch October 31, 2024 16:39
@github-actions github-actions bot mentioned this pull request Oct 31, 2024
@silesky silesky changed the title Fix runtime errors on signals, allow plain/text in response Fix runtime errors on signals, allow text/plain in response Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants