wip

segmentio · Oct 30, 2024 · bb2af15 · bb2af15
1 parent 1de5c29
commit bb2af15
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 4 deletions.
diff --git a/packages/signals/signals/src/core/buffer/__tests__/buffer.test.ts b/packages/signals/signals/src/core/buffer/__tests__/buffer.test.ts
@@ -16,7 +16,7 @@ describe(getSignalBuffer, () => {
   it('should add and clear', async () => {
     const mockSignal = createInteractionSignal({
       eventType: 'submit',
-      submitter: {},
+      target: {},
     })
     await buffer.add(mockSignal)
     await expect(buffer.getAll()).resolves.toEqual([mockSignal])

diff --git a/packages/signals/signals/src/core/client/__tests__/client.test.ts b/packages/signals/signals/src/core/client/__tests__/client.test.ts
@@ -44,6 +44,7 @@ describe(SignalsIngestClient, () => {
     const ctx = await client.send({
       type: 'network',
       data: {
+        contentType: 'application/json',
         action: 'request',
         data: {
           hello: 'how are you',
@@ -58,6 +59,7 @@ describe(SignalsIngestClient, () => {
     expect(ctx!.event.properties!.data).toMatchInlineSnapshot(`
       {
         "action": "request",
+        "contentType": "application/json",
         "data": {
           "hello": "XXX",
         },

diff --git a/packages/signals/signals/src/core/client/__tests__/redact.test.ts b/packages/signals/signals/src/core/client/__tests__/redact.test.ts
@@ -95,6 +95,7 @@ describe(redactSignalData, () => {
   it('should redact the values in the "data" property if the type is "network"', () => {
     const signal = createNetworkSignal(
       {
+        contentType: 'application/json',
         action: 'request',
         method: 'post',
         url: 'http://foo.com',
@@ -104,6 +105,7 @@ describe(redactSignalData, () => {
     )
     const expected = createNetworkSignal(
       {
+        contentType: 'application/json',
         action: 'request',
         method: 'post',
         url: 'http://foo.com',

diff --git a/packages/signals/signals/src/core/processor/__tests__/signals-runtime.test.ts b/packages/signals/signals/src/core/processor/__tests__/signals-runtime.test.ts
@@ -14,7 +14,7 @@ describe('SignalsRuntime', () => {
 
   beforeEach(() => {
     signal1 = createInstrumentationSignal({ type: 'track' })
-    signal2 = createInteractionSignal({ eventType: 'submit', submitter: {} })
+    signal2 = createInteractionSignal({ eventType: 'submit', target: {} })
     signal3 = createInteractionSignal({ eventType: 'change', target: {} })
     signalsRuntime = createSignalsRuntime([signal1, signal2, signal3])
   })

diff --git a/packages/signals/signals/src/types/signals.ts b/packages/signals/signals/src/types/signals.ts
@@ -78,21 +78,20 @@ interface BaseNetworkData {
   action: string
   url: string
   data: JSONValue
+  contentType: string
 }
 
 interface NetworkRequestData extends BaseNetworkData {
   action: 'request'
   url: string
   method: string
-  contentType: string
 }
 
 interface NetworkResponseData extends BaseNetworkData {
   action: 'response'
   url: string
   status: number
   ok: boolean
-  contentType: string
 }
 
 export type NetworkData = NetworkRequestData | NetworkResponseData