Adding a test to test overall persistence of userId and anonymousId. Change setCachedSettings: to not statically dispatch_once #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Change setCachedSettings: to not statically dispatch_once
Current coverage is 46.61% (diff: 80.00%)@@ dev #623 diff @@
==========================================
Files 79 79
Lines 2479 2484 +5
Methods 619 619
Messages 0 0
Branches 264 266 +2
==========================================
+ Hits 944 1158 +214
+ Misses 1419 1182 -237
- Partials 116 144 +28
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps ensure bug like #615 not happen again
cc @sperand-io @f2prateek