Initialize storage before generating anonymous ID. #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 3.5.0, a regression was introduced as part of the crypto changes that would cause a new anonymous ID to be generated for every launch of the app. This change fixes that regression.
|
@f2prateek if we used Swift for the core library this issue would have been caught by the compiler. Unfortunately we are not able to use Swift in the core library, but are there other ways this type of issues (nil pointer access silently dropped) could have been caught by maybe using nullability indicator? Unfortunately sending a message to nil is one of the most common kind of bugs on iOS because it is just so easy to make :( And it looks like we got hit by it. http://stackoverflow.com/questions/156395/sending-a-message-to-nil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 3.5.0 (https://github.com/segmentio/analytics-ios/pull/592/files), a regression was introduced as part of the crypto changes
that would cause a new anonymous ID to be generated for every launch of
the app.
This change fixes that regression.