Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run REPL in process #534

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Run REPL in process #534

merged 2 commits into from
Sep 21, 2021

Commits on Sep 21, 2021

  1. Run REPL in process 

    When skuba was first conceived, we were unsure if it would have much
staying power. As such, it stuck to extending regular config files and
executing command line tooling; the idea was that consumers could easily
offboard themselves by simply rolling their our underlying commands, and
we could fairly easily sunset skuba if it proved less than useful.

If we fast forward to the present, we are now held back by some of these
initial constraints. For example, sticking with a vanilla `tsc` means
that we can't perform compile-time import alias resolution, and the
abundance of `exec`ing is fairly wasteful as each one spins up its own
Node.js process with a separate V8 instance and all.

This is a simple first step: replace a trivial `exec` with a
pre-existing Node.js API that does the same thing. There's much more to
come in subsequent PRs.
    @72636c
    72636c committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    4e048e1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into repl-in-process

    @72636c
    72636c authored Sep 21, 2021
    Configuration menu
    Copy the full SHA
    512e416 View commit details
    Browse the repository at this point in the history