Run REPL in process #534
Merged
Run REPL in process #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When skuba was first conceived, we were unsure if it would have much staying power. As such, it stuck to extending regular config files and executing command line tooling; the idea was that consumers could easily offboard themselves by simply rolling their our underlying commands, and we could fairly easily sunset skuba if it proved less than useful. If we fast forward to the present, we are now held back by some of these initial constraints. For example, sticking with a vanilla `tsc` means that we can't perform compile-time import alias resolution, and the abundance of `exec`ing is fairly wasteful as each one spins up its own Node.js process with a separate V8 instance and all. This is a simple first step: replace a trivial `exec` with a pre-existing Node.js API that does the same thing. There's much more to come in subsequent PRs.
🦋 Changeset detectedLatest commit: 512e416 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
etaoins
approved these changes
Sep 21, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When skuba was first conceived, we were unsure if it would have much staying power. As such, it stuck to extending regular config files and executing command line tooling; the idea was that consumers could easily offboard themselves by simply rolling their own underlying commands, and we could fairly easily sunset skuba if it proved less than useful.
If we fast forward to the present, we are now held back by some of these initial constraints. For example, sticking with a vanilla
tscmeans that we can't perform compile-time import alias resolution, and the abundance ofexecing is fairly wasteful as each one spins up its own Node.js process with a separate V8 instance and all.This is a simple first step: replace a trivial
execwith a pre-existing Node.js API that does the same thing. There's much more to come in subsequent PRs.