redis: add prefetched dependencies, hermetic builds and unit tests #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lance
commented
Jan 31, 2024
•
lance
commented
- Updates the redis pipeline to use cachi2 and hermetic builds.
- Removes unit tests from the redis pipeline as that is not required for changes to the Dockerfile.
- Simplifies prefetch since we don't need to actually fetch anything.
- Finally, the cachi2 binary cannot handle go 1.21 yet. The apache/beam project recently reverted the use of 1.21 language features in [Go SDK] Don't depend on the go 1.21 standard lib yet apache/beam#30120 which should make it possible to run prefetched dependencies in the pipeline.
Updates the redis pipeline to use cachi2 and hermetic builds. Signed-off-by: Lance Ball <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lance The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Removes unit tests from the redis pipeline as that is not required for changes to the Dockerfile. Simplifies prefetch since we don't need to actually fetch anything. Signed-off-by: Lance Ball <[email protected]>
The cachi2 binary cannot handle go 1.21 yet. The apache/beam project recently reverted the use of 1.21 language features in apache/beam#30120 which should make it possible to run prefetched dependencies in the pipeline. Signed-off-by: Lance Ball <[email protected]>
lance
force-pushed
the
test-redis-prefetch
branch
from
8e61389 to
edf5def
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.