[Go SDK] Don't depend on the go 1.21 standard lib yet #30120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @zechenj18 |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #30120 +/- ##
==========================================
- Coverage 38.42% 38.41% -0.01%
==========================================
Files 697 697
Lines 102214 102214
==========================================
- Hits 39272 39263 -9
- Misses 61315 61322 +7
- Partials 1627 1629 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zechenj18
approved these changes
Jan 26, 2024
lance
added a commit
to securesign/trillian
that referenced
this pull request
Jan 31, 2024
The cachi2 binary cannot handle go 1.21 yet. The apache/beam project recently reverted the use of 1.21 language features in apache/beam#30120 which should make it possible to run prefetched dependencies in the pipeline. Signed-off-by: Lance Ball <[email protected]>
lance
added a commit
to securesign/trillian
that referenced
this pull request
Jan 31, 2024
) * chore: add prefetched dependencies and hermetic Updates the redis pipeline to use cachi2 and hermetic builds. Signed-off-by: Lance Ball <[email protected]> * chore: remove unit tests and simplify prefetch Removes unit tests from the redis pipeline as that is not required for changes to the Dockerfile. Simplifies prefetch since we don't need to actually fetch anything. Signed-off-by: Lance Ball <[email protected]> * deps: update apache/beam to the latest sha The cachi2 binary cannot handle go 1.21 yet. The apache/beam project recently reverted the use of 1.21 language features in apache/beam#30120 which should make it possible to run prefetched dependencies in the pipeline. Signed-off-by: Lance Ball <[email protected]> --------- Signed-off-by: Lance Ball <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beam is currently using go 1.20, but was accidentally depending on the go 1.21 standard libary versions of "maps" and "slices". This changes them to be the compatibility packages.
While beam advocates using the latest release (go 1.21) of Go when using it (which avoids problems when compiling those targets), the occasionally subtle dependency semantics allowed for that mismatch, leading to the compiler error. (IIRC this is not a problem past 1.21, which has better tooling awareness, but won't cause regressions for packages authored before those semantics...)
Going to cherry pick this into the 2.54.0 release to restore the compatibility with go 1.20.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.