Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes in dependency definitions #493

Merged
merged 3 commits into from
Jan 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,9 @@ Issues = "https://github.com/secure-systems-lab/securesystemslib/issues"
[project.optional-dependencies]
crypto = ["cryptography>=37.0.0"]
gcpkms = ["google-cloud-kms", "cryptography>=37.0.0"]
hsm = ["asn1crypto", "cryptography>=37.0.0", "PyKCS11"]
pynacl = ["pynacl>1.2.0"]
PySPX = ["PySPX==0.5.0"]
asn1 = ["asn1crypto"]
pykcs11 = ["PyKCS11"]
PySPX = ["PySPX>=0.5.0"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rugo, was there a specific reason for pinning this to 0.5.0. See 58857ca for why I changed this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, all good.


[tool.hatch.version]
path = "securesystemslib/__init__.py"
Expand Down
6 changes: 3 additions & 3 deletions requirements-pinned.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#
# This file is autogenerated by pip-compile with python 3.8
# To update, run:
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
# pip-compile --output-file=requirements-pinned.txt requirements.txt
#
Expand All @@ -11,7 +11,7 @@ cffi==1.15.1
# cryptography
# pynacl
# pyspx
cryptography==38.0.3 ; python_version >= "3"
cryptography==38.0.3
# via -r requirements.txt
pycparser==2.21
# via cffi
Expand Down
30 changes: 2 additions & 28 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,37 +1,11 @@
# All runtime requirements including extras (see 'install_requires' and
# 'extras_require' in setup.py)
# Requirements for full feature install (includes all optional dependencies).
#
# This file together with 'pip-compile' is used to generate a pinned
# requirements file with all immediate and transitive dependencies.
#
# 'requirements-pinned.txt' is updated on GitHub with Dependabot, which
# triggers CI/CD builds to automatically test against updated dependencies.
#
# Below instructions can be used to re-generate 'requirements-pinned.txt', e.g.
# if:
# - requirements are added or removed from this file
# - Python version support is changed
# - CI/CD build breaks due to updates (e.g. transitive dependency conflicts)
#
# 1. Use this script to create a pinned requirements file for each Python
# version
# ```
# for v in 3.7 3.8 3.9; do
# mkvirtualenv sslib-env-${v} -p python${v};
# pip install pip-tools;
# pip-compile --no-header -o requirements-${v}.txt requirements.txt;
# deactivate;
# rmvirtualenv sslib-env-${v};
# done;
#
# ```
# 2. Use this command to merge per-version files
# `sort -o requirements-pinned.txt -u requirements-?.?.txt`
# 2. Manually add environment markers to requirements-pinned.txt
# 3. Use this command to remove per-version files
# `rm requirements-?.?.txt`
#
cryptography >= 37.0.0; python_version >= '3'
cryptography >= 37.0.0
pynacl
PySPX
PyKCS11
Expand Down