Misc fixes in dependency definitions #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reverts 0928ceb, defining all optional dependencies needed for hsm signing and verification in one set. As discussed in secure-systems-lab#482, this makes more sense from a user perspective. The generic "crypto" (for cryptography) dependency is preserved to not annoy existing users. The new "hsm" dependency uses the same lower version bound for cryptography as "crypto", although it might work with lower versions. But it seems reasonable to keep constraints consistent. Signed-off-by: Lukas Puehringer <[email protected]>
We should not need to pin dependencies for user installation per default, but only if an update fails. This should be detected automatically by Dependabot-triggered builds. Signed-off-by: Lukas Puehringer <[email protected]>
- Removes version marker left over from Python 2 times, and instructions to semi-automatically generate a pinned requirements file. The latter was relevant when we had different requirements for different Python versions, which is not the case anymore. - Automatically re-generates requirements-pinned.txt Signed-off-by: Lukas Puehringer <[email protected]>
lukpueh
commented
Jan 11, 2023
| PySPX = ["PySPX==0.5.0"] | ||
| asn1 = ["asn1crypto"] | ||
| pykcs11 = ["PyKCS11"] | ||
| PySPX = ["PySPX>=0.5.0"] |
jku
approved these changes
Jan 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for details.