Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log a warning if colorama is not installed #211

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

FlorianVeaux
Copy link
Contributor

@FlorianVeaux FlorianVeaux commented Feb 24, 2020

Fixes issue #:
#210

Description of the changes being introduced by the pull request:
Remove the warning

Please verify and check that the pull request fulfils the following
requirements
:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

More details available on the issue #210

Additional notes:
This PR doesn't fix the issue that the logger has not been initialized correctly. (Shows only on Python2 with No handler could be found ...). This would require a bit more knowledge of the library and an easy workaround for library users is to use logging.raiseExceptions = False

@coveralls
Copy link

coveralls commented Feb 24, 2020

Coverage Status

Coverage remained the same at 98.712% when pulling e392647 on FlorianVeaux:master into 913beac on secure-systems-lab:master.

Copy link
Contributor

@trishankatdatadog trishankatdatadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukpueh
Copy link
Member

lukpueh commented Feb 25, 2020

Thanks pointing out these issues and providing a fix, @FlorianVeaux. We added the warning only recently (see #200). But you are right, a debug level message seems like a better fit. I'll merge this and follow up with a fix for the missing handler.

@lukpueh lukpueh merged commit 2f2dfa9 into secure-systems-lab:master Feb 25, 2020
@lukpueh lukpueh mentioned this pull request Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants