Module is logging warnings on import #210
Comments
This was referenced Feb 24, 2020
lukpueh
added a commit
to lukpueh/securesystemslib
that referenced
this issue
Feb 25, 2020
As pointed out by @FlorianVeaux in secure-systems-lab#210, securesystemslib does not correctly initialize its loggers. As a consequence the logging module logs a one-off "No handler could be found ..." warning when used for the first time (only on Python 2). The logging module then calls basicConfig, which attaches a basic StreamHandler to the root logger, to which securesystemslib's log messages are propagated. This commit adds the configuration of a simple securesystemslib top-level logger, with an attached StreamHandler and log level WARNING, to which all other securesystemslib loggers default.
lukpueh
added a commit
to lukpueh/securesystemslib
that referenced
this issue
Feb 25, 2020
As pointed out by @FlorianVeaux in secure-systems-lab#210, securesystemslib does not correctly initialize its loggers. As a consequence the logging module logs a one-off "No handler could be found ..." warning when used for the first time (only on Python 2). The logging module then calls basicConfig, which attaches a basic StreamHandler to the root logger, to which securesystemslib's log messages are propagated. This commit adds the configuration of a simple securesystemslib top-level logger, with an attached StreamHandler and log level WARNING, to which all other securesystemslib loggers default. This removes the one-off warning, while providing a similar logging behavior as before and clear instructions (see added comments) on how to customize (format, silence, etc...) securesystemslib's logging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello 👋
Description of issue or feature request:
When
securesystemslibis installed without thecolorsextra, warnings/error logs are shown.Current behavior:
On Python3, it complains about the colorama module not being found here
On Python2, it tries to complain for the same thing but is failing with the
No handlers could be found for logger "securesystemslib_interface".Expected behavior:
The library should not complain about colorama as it is an optional dependency (and should also initialize the logger correctly on Python2)
How to reproduce:
Python2:
docker run -it python:2 bash -c "pip install securesystemslib[crypto,pynacl] && python -c 'import securesystemslib.interface'"Python3:
docker run -it python:3 bash -c "pip install securesystemslib[crypto,pynacl] && python -c 'import securesystemslib.interface'"The text was updated successfully, but these errors were encountered: