Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of unbalanced returns for IIA #664

Merged
merged 7 commits into from
Sep 6, 2023
Merged

Fix handling of unbalanced returns for IIA #664

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
036db8c
fix handling of unbalanced returns for IIA, for the change in the IDE…
Aug 28, 2023
77139f7
Update include/phasar/PhasarLLVM/DataFlow/IfdsIde/Problems/IDEInstInt…
MMory Aug 28, 2023
750499d
Merge branch 'development' into f-FixUnbalancedReturnHandlingIIA
fabianbs96 Aug 28, 2023
9858e23
Merge branch 'development' into f-FixUnbalancedReturnHandlingIIA
fabianbs96 Aug 28, 2023
1c218ae
Fix error due to update from dev
fabianbs96 Aug 28, 2023
0970312
Separate APi for side-effets of ret-FF in case of unbalanced-return end
fabianbs96 Aug 30, 2023
f05739e
pre-commit
fabianbs96 Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/phasar/DataFlow/IfdsIde/Solver/IDESolver.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,8 +886,8 @@ class IDESolver
// conditionally generated values should only
// be propagated into callers that have an incoming edge for this
// condition
if (SolverConfig.followReturnsPastSeeds() && Inc.empty() &&
IDEProblem.isZeroValue(d1)) {
if (SolverConfig.followReturnsPastSeeds() && Inc.empty() /*&&
IDEProblem.isZeroValue(d1)*/) {
const auto &Callers = ICF->getCallersOf(FunctionThatNeedsSummary);
for (n_t Caller : Callers) {
for (n_t RetSiteC : ICF->getReturnSitesOfCallAt(Caller)) {
Expand Down
4 changes: 3 additions & 1 deletion include/phasar/PhasarLLVM/DataFlow/IfdsIde/Problems/IDEInstInteractionAnalysis.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,9 @@ class IDEInstInteractionAnalysisT
n_t /* RetSite */) override {
// Map return value back to the caller. If pointer parameters hold at the
// end of a callee function generate all of those in the caller context.

if (CallSite == nullptr) {
return killAllFlows<d_t>();
}
auto MapFactsToCallerFF =
mapFactsToCaller<d_t>(llvm::cast<llvm::CallBase>(CallSite), ExitInst,
{}, [](const llvm::Value *RetVal, d_t Src) {
Expand Down