Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of unbalanced returns for IIA #664

Merged
merged 7 commits into from
Sep 6, 2023

Conversation

MMory
Copy link
Member

@MMory MMory commented Aug 28, 2023

For the change in the IDE solver I am not sure yet how this should be done properly, let's discuss that @fabianbs96

… solver I am not sure yet how this should be done properly.
…eractionAnalysis.h

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Collaborator

@vulder vulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my point of view, this should work. However, I cannot say that removing the isZeroValue check is save.

@fabianbs96
Copy link
Member

fabianbs96 commented Aug 28, 2023

@MMory I suppose this is correct; otherwise we cannot propagate back seed parameters in an unbalanced return, however, I don't know the exact reason for this being introduced (this is already there in Heros). On the other hand, for what use case do you need this?

Regarding the null-check on CallSite in the ret-FF, I don't think, this is the way to go. We should rather change the one location in the IDESolver where the call-site is passed nullptr an extra API in the IDETabulationProblem that can be overridden if required (I think, this is required only very rarely). Further, as the IDESolver is generic over the to be analyzed IR, we should also be able to handle statement (n_t) types that are not nullable.

EDIT: The second part may be a separate PR, or what do you think?

@MMory MMory merged commit c78dbe0 into development Sep 6, 2023
@MMory MMory deleted the f-FixUnbalancedReturnHandlingIIA branch September 6, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants