-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of unbalanced returns for IIA #664
Conversation
… solver I am not sure yet how this should be done properly.
include/phasar/PhasarLLVM/DataFlow/IfdsIde/Problems/IDEInstInteractionAnalysis.h
Outdated
Show resolved
Hide resolved
…eractionAnalysis.h Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my point of view, this should work. However, I cannot say that removing the isZeroValue check is save.
@MMory I suppose this is correct; otherwise we cannot propagate back seed parameters in an unbalanced return, however, I don't know the exact reason for this being introduced (this is already there in Heros). On the other hand, for what use case do you need this? Regarding the null-check on EDIT: The second part may be a separate PR, or what do you think? |
For the change in the IDE solver I am not sure yet how this should be done properly, let's discuss that @fabianbs96