-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support accessor keyword in class properties #353
Conversation
I've updated the test suite so if you rebase and remove lines from |
will do, at first i need to fix broken tests |
@lahma please review. I also needed to add some tests to the allow list, cause the generated _characterData seems not to be correct. But I did not understand the regex to fit it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me, the allow list shows that we are moving to the right direction. I'm willing to merge if ready, we probably need more cleanup to the class parsing logic later like you've discovered that it's a bit complex.
So should we merge?
for me it's ready, i'm done atm |
Thanks for going through the spec and implementation, always appreciated! |
No description provided.