-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong handling of private Identifierers #354
Comments
jogibear9988
added a commit
to jogibear9988/esprima-dotnet
that referenced
this issue
Dec 25, 2022
This should now be covered too. |
Unfortunately, not completely. Static private property and method declarations like class X {
static #privateField = 'super';
static #getPrivateField() {
return X.#privateField;
}
} are still parsed incorrectly as |
fixed in my pull, missed one parameter |
lahma
pushed a commit
to jogibear9988/esprima-dotnet
that referenced
this issue
Dec 29, 2022
lahma
pushed a commit
that referenced
this issue
Dec 29, 2022
* fix computed properties in classes * throw an error when "arguments" is used as the value for a property (… * hacky fix some regex problems which occurred due to different parsers * allow trailing "," in import * allow trailing second "," in import * throw error on deletion of private fields * attributes on import could be a expression * fix super access in methods * many arguments is not invalid any more * bugfix private static class members, fixes #354 * fix property access * updated allow list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Try this:
We do not create an instance of PrivateIdentifier. We create a normal node with "#" in the value
The text was updated successfully, but these errors were encountered: