Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove withConsecutive() #4564

Closed
sebastianbergmann opened this issue Dec 28, 2020 · 3 comments
Closed

Remove withConsecutive() #4564

sebastianbergmann opened this issue Dec 28, 2020 · 3 comments
Assignees
@sebastianbergmann
Labels
feature/test-doubles Test Stubs and Mock Objects type/deprecation Something will be/is deprecated
Milestone
PHPUnit 10.0

Comments

@sebastianbergmann
Copy link
Owner

See #4255 (comment) for details.
@sebastianbergmann sebastianbergmann added feature/test-doubles Test Stubs and Mock Objects type/deprecation Something will be/is deprecated labels Dec 28, 2020
@sebastianbergmann sebastianbergmann added this to the PHPUnit 10.0 milestone Dec 28, 2020
@sebastianbergmann sebastianbergmann self-assigned this Dec 28, 2020
@sebastianbergmann sebastianbergmann mentioned this issue Dec 28, 2020
Closed
@dbrekelmans dbrekelmans mentioned this issue Apr 29, 2021
Closed
@davidbyoung davidbyoung mentioned this issue Oct 9, 2021
Closed
@TomasVotruba TomasVotruba mentioned this issue Apr 23, 2022
Merged
@morozov morozov mentioned this issue May 3, 2022
Merged
6 tasks
@sebastianbergmann sebastianbergmann changed the title Deprecate withConsecutive() Remove withConsecutive() Aug 11, 2022
@jrfnl jrfnl mentioned this issue Aug 25, 2022
Closed
11 tasks
@mondrake
Copy link

withConsecutive() is now going from fully available in 9.5 to fully removed in 10.0, with no deprecation process in between to allow projects to react. Shall a deprecation be added to 9.5?

Also see https://www.drupal.org/project/drupal/issues/3306554

@mondrake mondrake mentioned this issue Aug 30, 2022
Closed
@sebastianbergmann sebastianbergmann mentioned this issue Sep 25, 2022
Closed
@LordSimal LordSimal mentioned this issue Feb 3, 2023
Merged
BafS referenced this issue in wikimedia/mediawiki-libs-Equivset Feb 3, 2023
@umherirrender
tests: Replace logicalOr() with withConsecutive() to be more strict
50a1d95 
Remove two lines from the error messages to handle both error cases
similiar.
Fix the wrong character in the error message as well

Change-Id: Ied154e8232c8e13e619706939833809110b9757b
@SimonFrings SimonFrings mentioned this issue Feb 8, 2023
Closed
@alexandre-daubois alexandre-daubois mentioned this issue Mar 6, 2023
Merged
nicolas-grekas added a commit to symfony/symfony that referenced this issue Mar 10, 2023
@nicolas-grekas
minor #49621 [Tests] Remove occurrences of withConsecutive() (alexa…
431b6ef 
…ndre-daubois)

This PR was merged into the 5.4 branch.

Discussion
----------

[Tests] Remove occurrences of `withConsecutive()`

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

`withConsecutive()` has been deprecated in PHPUnit 9.6 and removed in PHP 10 (sebastianbergmann/phpunit#4564). This PR aims at starting the work to remove these occurrences. There is unfortunately no given migration path, and this requires manual work.

I'll create a meta issue referencing remaining occurrences if this one's merged, to keep track. Some seems pretty hard to remove.

cc `@OskarStark` this might interest you, as we worked a lot on tests lately 😄

Commits
-------

2047763 [Tests] Remove occurrences of `withConsecutive()`
symfony-splitter pushed a commit to symfony/security-core that referenced this issue Mar 10, 2023
@nicolas-grekas
minor #49621 [Tests] Remove occurrences of withConsecutive() (alexa…
a801d52 
…ndre-daubois)

This PR was merged into the 5.4 branch.

Discussion
----------

[Tests] Remove occurrences of `withConsecutive()`

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

`withConsecutive()` has been deprecated in PHPUnit 9.6 and removed in PHP 10 (sebastianbergmann/phpunit#4564). This PR aims at starting the work to remove these occurrences. There is unfortunately no given migration path, and this requires manual work.

I'll create a meta issue referencing remaining occurrences if this one's merged, to keep track. Some seems pretty hard to remove.

cc `@OskarStark` this might interest you, as we worked a lot on tests lately 😄

Commits
-------

2047763649 [Tests] Remove occurrences of `withConsecutive()`
symfony-splitter pushed a commit to symfony/twig-bridge that referenced this issue Mar 10, 2023
@nicolas-grekas
minor #49621 [Tests] Remove occurrences of withConsecutive() (alexa…
355db9a 
…ndre-daubois)

This PR was merged into the 5.4 branch.

Discussion
----------

[Tests] Remove occurrences of `withConsecutive()`

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

`withConsecutive()` has been deprecated in PHPUnit 9.6 and removed in PHP 10 (sebastianbergmann/phpunit#4564). This PR aims at starting the work to remove these occurrences. There is unfortunately no given migration path, and this requires manual work.

I'll create a meta issue referencing remaining occurrences if this one's merged, to keep track. Some seems pretty hard to remove.

cc `@OskarStark` this might interest you, as we worked a lot on tests lately 😄

Commits
-------

2047763649 [Tests] Remove occurrences of `withConsecutive()`
symfony-splitter pushed a commit to symfony/http-kernel that referenced this issue Mar 10, 2023
@nicolas-grekas
minor #49621 [Tests] Remove occurrences of withConsecutive() (alexa…
7fdbb6b 
…ndre-daubois)

This PR was merged into the 5.4 branch.

Discussion
----------

[Tests] Remove occurrences of `withConsecutive()`

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

`withConsecutive()` has been deprecated in PHPUnit 9.6 and removed in PHP 10 (sebastianbergmann/phpunit#4564). This PR aims at starting the work to remove these occurrences. There is unfortunately no given migration path, and this requires manual work.

I'll create a meta issue referencing remaining occurrences if this one's merged, to keep track. Some seems pretty hard to remove.

cc `@OskarStark` this might interest you, as we worked a lot on tests lately 😄

Commits
-------

2047763649 [Tests] Remove occurrences of `withConsecutive()`
symfony-splitter pushed a commit to symfony/dependency-injection that referenced this issue Mar 10, 2023
@nicolas-grekas
minor #49621 [Tests] Remove occurrences of withConsecutive() (alexa…
e1b7c14 
…ndre-daubois)

This PR was merged into the 5.4 branch.

Discussion
----------

[Tests] Remove occurrences of `withConsecutive()`

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

`withConsecutive()` has been deprecated in PHPUnit 9.6 and removed in PHP 10 (sebastianbergmann/phpunit#4564). This PR aims at starting the work to remove these occurrences. There is unfortunately no given migration path, and this requires manual work.

I'll create a meta issue referencing remaining occurrences if this one's merged, to keep track. Some seems pretty hard to remove.

cc `@OskarStark` this might interest you, as we worked a lot on tests lately 😄

Commits
-------

2047763649 [Tests] Remove occurrences of `withConsecutive()`
symfony-splitter pushed a commit to symfony/http-foundation that referenced this issue Mar 10, 2023
@nicolas-grekas
minor #49621 [Tests] Remove occurrences of withConsecutive() (alexa…
c63f733 
…ndre-daubois)

This PR was merged into the 5.4 branch.

Discussion
----------

[Tests] Remove occurrences of `withConsecutive()`

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

`withConsecutive()` has been deprecated in PHPUnit 9.6 and removed in PHP 10 (sebastianbergmann/phpunit#4564). This PR aims at starting the work to remove these occurrences. There is unfortunately no given migration path, and this requires manual work.

I'll create a meta issue referencing remaining occurrences if this one's merged, to keep track. Some seems pretty hard to remove.

cc `@OskarStark` this might interest you, as we worked a lot on tests lately 😄

Commits
-------

2047763649 [Tests] Remove occurrences of `withConsecutive()`
symfony-splitter pushed a commit to symfony/security-http that referenced this issue Mar 10, 2023
@nicolas-grekas
minor #49621 [Tests] Remove occurrences of withConsecutive() (alexa…
428c849 
…ndre-daubois)

This PR was merged into the 5.4 branch.

Discussion
----------

[Tests] Remove occurrences of `withConsecutive()`

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

`withConsecutive()` has been deprecated in PHPUnit 9.6 and removed in PHP 10 (sebastianbergmann/phpunit#4564). This PR aims at starting the work to remove these occurrences. There is unfortunately no given migration path, and this requires manual work.

I'll create a meta issue referencing remaining occurrences if this one's merged, to keep track. Some seems pretty hard to remove.

cc `@OskarStark` this might interest you, as we worked a lot on tests lately 😄

Commits
-------

2047763649 [Tests] Remove occurrences of `withConsecutive()`
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this issue Mar 10, 2023
@nicolas-grekas
minor #49621 [Tests] Remove occurrences of withConsecutive() (alexa…
4cc8645 
…ndre-daubois)

This PR was merged into the 5.4 branch.

Discussion
----------

[Tests] Remove occurrences of `withConsecutive()`

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

`withConsecutive()` has been deprecated in PHPUnit 9.6 and removed in PHP 10 (sebastianbergmann/phpunit#4564). This PR aims at starting the work to remove these occurrences. There is unfortunately no given migration path, and this requires manual work.

I'll create a meta issue referencing remaining occurrences if this one's merged, to keep track. Some seems pretty hard to remove.

cc `@OskarStark` this might interest you, as we worked a lot on tests lately 😄

Commits
-------

2047763649 [Tests] Remove occurrences of `withConsecutive()`
symfony-splitter pushed a commit to symfony/cache that referenced this issue Mar 10, 2023
@nicolas-grekas
minor #49621 [Tests] Remove occurrences of withConsecutive() (alexa…
5b211b1 
…ndre-daubois)

This PR was merged into the 5.4 branch.

Discussion
----------

[Tests] Remove occurrences of `withConsecutive()`

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

`withConsecutive()` has been deprecated in PHPUnit 9.6 and removed in PHP 10 (sebastianbergmann/phpunit#4564). This PR aims at starting the work to remove these occurrences. There is unfortunately no given migration path, and this requires manual work.

I'll create a meta issue referencing remaining occurrences if this one's merged, to keep track. Some seems pretty hard to remove.

cc `@OskarStark` this might interest you, as we worked a lot on tests lately 😄

Commits
-------

2047763649 [Tests] Remove occurrences of `withConsecutive()`
symfony-splitter pushed a commit to symfony/security-bundle that referenced this issue Mar 10, 2023
@nicolas-grekas
minor #49621 [Tests] Remove occurrences of withConsecutive() (alexa…
36eddff 
…ndre-daubois)

This PR was merged into the 5.4 branch.

Discussion
----------

[Tests] Remove occurrences of `withConsecutive()`

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

`withConsecutive()` has been deprecated in PHPUnit 9.6 and removed in PHP 10 (sebastianbergmann/phpunit#4564). This PR aims at starting the work to remove these occurrences. There is unfortunately no given migration path, and this requires manual work.

I'll create a meta issue referencing remaining occurrences if this one's merged, to keep track. Some seems pretty hard to remove.

cc `@OskarStark` this might interest you, as we worked a lot on tests lately 😄

Commits
-------

2047763649 [Tests] Remove occurrences of `withConsecutive()`
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue May 6, 2023
@BacLuc
Camp(Create,Remove)ProcessorTest: use willReturnOnConsecutiveCalls
1117b58 
Instead of the deprecated WithConsecutive.
See sebastianbergmann/phpunit#4564

Issue: ecamp#3337
usu pushed a commit to ecamp/ecamp3 that referenced this issue May 12, 2023
@BacLuc @usu
Camp(Create,Remove)ProcessorTest: use willReturnOnConsecutiveCalls
49c1abd 
Instead of the deprecated WithConsecutive.
See sebastianbergmann/phpunit#4564

Issue: #3337
@Seldaek Seldaek mentioned this issue Jun 7, 2023
Merged
@jrfnl jrfnl mentioned this issue Jun 12, 2023
Merged
morozov added a commit to morozov/dbal that referenced this issue Jun 13, 2023
@morozov
Get rid of the usage of InvocationMocker::withConsecutive()
9a8b74e 
See: sebastianbergmann/phpunit#4564
morozov added a commit to morozov/dbal that referenced this issue Jun 13, 2023
@morozov
Get rid of the usage of InvocationMocker::withConsecutive()
ae0b061 
See: sebastianbergmann/phpunit#4564
morozov added a commit to morozov/dbal that referenced this issue Jun 13, 2023
@morozov
Get rid of the usage of InvocationMocker::withConsecutive()
56ce7db 
See: sebastianbergmann/phpunit#4564
morozov added a commit to morozov/dbal that referenced this issue Jun 13, 2023
@morozov
Get rid of the usage of InvocationMocker::withConsecutive()
b5a2f0e 
See: sebastianbergmann/phpunit#4564
morozov added a commit to morozov/dbal that referenced this issue Jun 14, 2023
@morozov
Get rid of the usage of InvocationMocker::withConsecutive()
349039d 
See: sebastianbergmann/phpunit#4564
morozov added a commit to morozov/dbal that referenced this issue Jun 14, 2023
@morozov
Get rid of the usage of InvocationMocker::withConsecutive()
dd2e297 
See: sebastianbergmann/phpunit#4564
morozov added a commit to morozov/dbal that referenced this issue Jun 14, 2023
@morozov
Get rid of the usage of InvocationMocker::withConsecutive()
9be3e34 
See: sebastianbergmann/phpunit#4564
morozov added a commit to morozov/dbal that referenced this issue Jun 14, 2023
@morozov
Get rid of the usage of InvocationMocker::withConsecutive()
bf280f1 
See: sebastianbergmann/phpunit#4564
@dontub dontub mentioned this issue Jun 28, 2023
Open
@oleg-andreyev
Copy link

workaround: https://gist.github.com/oleg-andreyev/85c74dbf022237b03825c7e9f4439303

symfony-splitter pushed a commit to symfony/framework-bundle that referenced this issue Jul 28, 2023
@nicolas-grekas
minor #49621 [Tests] Remove occurrences of withConsecutive() (alexa…
4b1d04e 
…ndre-daubois)

This PR was merged into the 5.4 branch.

Discussion
----------

[Tests] Remove occurrences of `withConsecutive()`

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

`withConsecutive()` has been deprecated in PHPUnit 9.6 and removed in PHP 10 (sebastianbergmann/phpunit#4564). This PR aims at starting the work to remove these occurrences. There is unfortunately no given migration path, and this requires manual work.

I'll create a meta issue referencing remaining occurrences if this one's merged, to keep track. Some seems pretty hard to remove.

cc `@OskarStark` this might interest you, as we worked a lot on tests lately 😄

Commits
-------

2047763649 [Tests] Remove occurrences of `withConsecutive()`
@pkvach pkvach mentioned this issue Mar 3, 2024
Merged
5 tasks
@Seb35 Seb35 mentioned this issue Sep 23, 2024
Open
@TomasVotruba
Copy link

There are around ~10 variations of how PHPUnit withConsecutive() can be upgraded. If there is a reference, followed by willReturn*() or by willReturnOnConsecutive() and more.

Instead of creating answer that fits only one specific quesition, I've put down an article that explains, how to upgrade all kind of combinations.

See:
https://tomasvotruba.com/blog/how-to-upgrade-deprecated-phpunit-with-consecutive

Hopefully you'll find it useful.

It includes PHP 7.* ready code (no match), that can be used in PHPUnit 9 (that requires 7.3+)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastianbergmann sebastianbergmann

Labels
feature/test-doubles Test Stubs and Mock Objects type/deprecation Something will be/is deprecated
Projects
None yet
Milestone
PHPUnit 10.0
Development

No branches or pull requests
4 participants
@sebastianbergmann @TomasVotruba @mondrake @oleg-andreyev