Implement specialized alternatives to assertInternalType() and assertNotInternalType() #3368

sebastianbergmann · 2018-10-24T11:56:55Z

Implement

assertIsArray()
assertIsBool()
assertIsFloat()
assertIsInt()
assertIsNumeric()
assertIsObject()
assertIsResource()
assertIsString()
assertIsScalar()
assertIsCallable()
assertIsIterable()
assertIsNotArray()
assertIsNotBool()
assertIsNotFloat()
assertIsNotInt()
assertIsNotNumeric()
assertIsNotObject()
assertIsNotResource()
assertIsNotString()
assertIsNotScalar()
assertIsNotCallable()
assertIsNotIterable()

The text was updated successfully, but these errors were encountered:

keradus · 2018-10-25T22:26:33Z

can you elaborate on that one, @sebastianbergmann ?
looks like lot of new assertions

I agree that with assertInternalType it's easy to make a typo with provided type, like bol instead of bool, yet even if one would do the typo, then when he run tests assertion will fail anyway

TomasVotruba · 2018-12-31T12:06:32Z

What will happen to same checks just for arrays?

$this->assertContainsOnly('string', $types);

sebastianbergmann/phpunit#3368

glensc · 2019-02-09T12:10:59Z

what phpunit min version has the new assertions?

sebastianbergmann · 2019-02-09T12:12:09Z

These assertions were implemented for PHPUnit 7.5.

glensc · 2019-02-09T12:39:57Z

what's the replacement for such code:

        $this->assertInternalType(gettype($algo), $res['algo']);

nelson6e65 · 2019-02-09T22:35:42Z

what's the replacement for such code:
        $this->assertInternalType(gettype($algo), $res['algo']);

@glensc Maybe...

$assertIsType = 'assertIs'.gettype($algo);

$this->$assertIsType($res['algo']);

But... if you need this dynamic, you may need a redesign of the test. 😅

JeroenDeDauw · 2020-02-24T23:47:54Z

Is there a way to make these available in PHPUnit 6?

I'd be tempted to reply to my own question with "just use a modern version of PHPUnit", so here some background of why this change sucks for me. I maintain a number of MediaWiki extensions. The development version of MediaWiki uses PHPUnit 8, so no problems there. However the latest LTS uses PHPUnit 6. Which means I cannot use the new assertion methods introduced in PHPUnit 7.5. So I'm forced to either write instant legacy assertions and live with a pile of warnings, or to drop testing against a very relevant version of MediaWiki from the CI.

nelson6e65 · 2020-03-01T07:21:07Z

Is there a way to make these available in PHPUnit 6?

I'd be tempted to reply to my own question with "just use a modern version of PHPUnit", so here some background of why this change sucks for me. I maintain a number of MediaWiki extensions. The development version of MediaWiki uses PHPUnit 8, so no problems there. However the latest LTS uses PHPUnit 6. Which means I cannot use the new assertion methods introduced in PHPUnit 7.5. So I'm forced to either write instant legacy assertions and live with a pile of warnings, or to drop testing against a very relevant version of MediaWiki from the CI.

Well... there are the changes in a406c85#diff-9ae7a972d07df5f73629d5d315bf405a

Yo can create a trait with that methods and try to use it in your tests classes.

JeroenDeDauw · 2020-03-01T11:46:23Z

Thanks for the link. I asked here in the hope there already is a package that provides a copy.

joelmellon · 2020-03-26T12:33:27Z

what's the replacement for such code:
        $this->assertInternalType(gettype($algo), $res['algo']);

$this->assertEquals(gettype($algo), gettype($res['algo']));

…tIs[Not]Array()` The `assertInternalType()` and `assertNotInternalType()` methods were soft deprecated in PHPUnit 7.5, hard deprecated in PHPUnit 8.0 and the functionality was removed in PHPUnit 9.0. The more specific `assertIsArray()`, `assertIsNotArray()`, `assertIsBool()`, `assertIsNotBool()`, `assertIsFloat()`, `assertIsNotFloat()`, `assertIsInt()`, `assertIsNotInt()`, `assertIsNumeric()`, `assertIsNotNumeric()`, `assertIsObject()`, `assertIsNotObject()`, `assertIsResource()`, `assertIsNotResource()`, `assertIsString()`, `assertIsNotString()`, `assertIsScalar()`, `assertIsNotScalar()`, `assertIsCallable()`, `assertIsNotCallable()`, `assertIsIterable()`, `assertIsNotIterable()` methods were introduced as replacements in PHPUnit 7.5. Ref: * https://github.com/sebastianbergmann/phpunit/blob/7.5.20/ChangeLog-7.5.md#750---2018-12-07 * sebastianbergmann/phpunit#3368

…Is[Not]Bool()` The `assertInternalType()` and `assertNotInternalType()` methods were soft deprecated in PHPUnit 7.5, hard deprecated in PHPUnit 8.0 and the functionality was removed in PHPUnit 9.0. The more specific `assertIsArray()`, `assertIsNotArray()`, `assertIsBool()`, `assertIsNotBool()`, `assertIsFloat()`, `assertIsNotFloat()`, `assertIsInt()`, `assertIsNotInt()`, `assertIsNumeric()`, `assertIsNotNumeric()`, `assertIsObject()`, `assertIsNotObject()`, `assertIsResource()`, `assertIsNotResource()`, `assertIsString()`, `assertIsNotString()`, `assertIsScalar()`, `assertIsNotScalar()`, `assertIsCallable()`, `assertIsNotCallable()`, `assertIsIterable()`, `assertIsNotIterable()` methods were introduced as replacements in PHPUnit 7.5. Ref: * https://github.com/sebastianbergmann/phpunit/blob/7.5.20/ChangeLog-7.5.md#750---2018-12-07 * sebastianbergmann/phpunit#3368

…tIs[Not]Float()` The `assertInternalType()` and `assertNotInternalType()` methods were soft deprecated in PHPUnit 7.5, hard deprecated in PHPUnit 8.0 and the functionality was removed in PHPUnit 9.0. The more specific `assertIsArray()`, `assertIsNotArray()`, `assertIsBool()`, `assertIsNotBool()`, `assertIsFloat()`, `assertIsNotFloat()`, `assertIsInt()`, `assertIsNotInt()`, `assertIsNumeric()`, `assertIsNotNumeric()`, `assertIsObject()`, `assertIsNotObject()`, `assertIsResource()`, `assertIsNotResource()`, `assertIsString()`, `assertIsNotString()`, `assertIsScalar()`, `assertIsNotScalar()`, `assertIsCallable()`, `assertIsNotCallable()`, `assertIsIterable()`, `assertIsNotIterable()` methods were introduced as replacements in PHPUnit 7.5. Ref: * https://github.com/sebastianbergmann/phpunit/blob/7.5.20/ChangeLog-7.5.md#750---2018-12-07 * sebastianbergmann/phpunit#3368

…s[Not]Int()` The `assertInternalType()` and `assertNotInternalType()` methods were soft deprecated in PHPUnit 7.5, hard deprecated in PHPUnit 8.0 and the functionality was removed in PHPUnit 9.0. The more specific `assertIsArray()`, `assertIsNotArray()`, `assertIsBool()`, `assertIsNotBool()`, `assertIsFloat()`, `assertIsNotFloat()`, `assertIsInt()`, `assertIsNotInt()`, `assertIsNumeric()`, `assertIsNotNumeric()`, `assertIsObject()`, `assertIsNotObject()`, `assertIsResource()`, `assertIsNotResource()`, `assertIsString()`, `assertIsNotString()`, `assertIsScalar()`, `assertIsNotScalar()`, `assertIsCallable()`, `assertIsNotCallable()`, `assertIsIterable()`, `assertIsNotIterable()` methods were introduced as replacements in PHPUnit 7.5. Ref: * https://github.com/sebastianbergmann/phpunit/blob/7.5.20/ChangeLog-7.5.md#750---2018-12-07 * sebastianbergmann/phpunit#3368

…tIs[Not]Float()` The `assertInternalType()` and `assertNotInternalType()` methods were soft deprecated in PHPUnit 7.5, hard deprecated in PHPUnit 8.0 and the functionality was removed in PHPUnit 9.0. The more specific `assertIsArray()`, `assertIsNotArray()`, `assertIsBool()`, `assertIsNotBool()`, `assertIsFloat()`, `assertIsNotFloat()`, `assertIsInt()`, `assertIsNotInt()`, `assertIsNumeric()`, `assertIsNotNumeric()`, `assertIsObject()`, `assertIsNotObject()`, `assertIsResource()`, `assertIsNotResource()`, `assertIsString()`, `assertIsNotString()`, `assertIsScalar()`, `assertIsNotScalar()`, `assertIsCallable()`, `assertIsNotCallable()`, `assertIsIterable()`, `assertIsNotIterable()` methods were introduced as replacements in PHPUnit 7.5. Ref: * https://github.com/sebastianbergmann/phpunit/blob/7.5.20/ChangeLog-7.5.md#750---2018-12-07 * sebastianbergmann/phpunit#3368

…s[Not]Int()` The `assertInternalType()` and `assertNotInternalType()` methods were soft deprecated in PHPUnit 7.5, hard deprecated in PHPUnit 8.0 and the functionality was removed in PHPUnit 9.0. The more specific `assertIsArray()`, `assertIsNotArray()`, `assertIsBool()`, `assertIsNotBool()`, `assertIsFloat()`, `assertIsNotFloat()`, `assertIsInt()`, `assertIsNotInt()`, `assertIsNumeric()`, `assertIsNotNumeric()`, `assertIsObject()`, `assertIsNotObject()`, `assertIsResource()`, `assertIsNotResource()`, `assertIsString()`, `assertIsNotString()`, `assertIsScalar()`, `assertIsNotScalar()`, `assertIsCallable()`, `assertIsNotCallable()`, `assertIsIterable()`, `assertIsNotIterable()` methods were introduced as replacements in PHPUnit 7.5. Ref: * https://github.com/sebastianbergmann/phpunit/blob/7.5.20/ChangeLog-7.5.md#750---2018-12-07 * sebastianbergmann/phpunit#3368 Includes removing a few assignments made within function calls.

…rtIs[Not]Object()` The `assertInternalType()` and `assertNotInternalType()` methods were soft deprecated in PHPUnit 7.5, hard deprecated in PHPUnit 8.0 and the functionality was removed in PHPUnit 9.0. The more specific `assertIsArray()`, `assertIsNotArray()`, `assertIsBool()`, `assertIsNotBool()`, `assertIsFloat()`, `assertIsNotFloat()`, `assertIsInt()`, `assertIsNotInt()`, `assertIsNumeric()`, `assertIsNotNumeric()`, `assertIsObject()`, `assertIsNotObject()`, `assertIsResource()`, `assertIsNotResource()`, `assertIsString()`, `assertIsNotString()`, `assertIsScalar()`, `assertIsNotScalar()`, `assertIsCallable()`, `assertIsNotCallable()`, `assertIsIterable()`, `assertIsNotIterable()` methods were introduced as replacements in PHPUnit 7.5. Ref: * https://github.com/sebastianbergmann/phpunit/blob/7.5.20/ChangeLog-7.5.md#750---2018-12-07 * sebastianbergmann/phpunit#3368

…sertIs[Not]Resource()` The `assertInternalType()` and `assertNotInternalType()` methods were soft deprecated in PHPUnit 7.5, hard deprecated in PHPUnit 8.0 and the functionality was removed in PHPUnit 9.0. The more specific `assertIsArray()`, `assertIsNotArray()`, `assertIsBool()`, `assertIsNotBool()`, `assertIsFloat()`, `assertIsNotFloat()`, `assertIsInt()`, `assertIsNotInt()`, `assertIsNumeric()`, `assertIsNotNumeric()`, `assertIsObject()`, `assertIsNotObject()`, `assertIsResource()`, `assertIsNotResource()`, `assertIsString()`, `assertIsNotString()`, `assertIsScalar()`, `assertIsNotScalar()`, `assertIsCallable()`, `assertIsNotCallable()`, `assertIsIterable()`, `assertIsNotIterable()` methods were introduced as replacements in PHPUnit 7.5. Ref: * https://github.com/sebastianbergmann/phpunit/blob/7.5.20/ChangeLog-7.5.md#750---2018-12-07 * sebastianbergmann/phpunit#3368

…rtIs[Not]String()` The `assertInternalType()` and `assertNotInternalType()` methods were soft deprecated in PHPUnit 7.5, hard deprecated in PHPUnit 8.0 and the functionality was removed in PHPUnit 9.0. The more specific `assertIsArray()`, `assertIsNotArray()`, `assertIsBool()`, `assertIsNotBool()`, `assertIsFloat()`, `assertIsNotFloat()`, `assertIsInt()`, `assertIsNotInt()`, `assertIsNumeric()`, `assertIsNotNumeric()`, `assertIsObject()`, `assertIsNotObject()`, `assertIsResource()`, `assertIsNotResource()`, `assertIsString()`, `assertIsNotString()`, `assertIsScalar()`, `assertIsNotScalar()`, `assertIsCallable()`, `assertIsNotCallable()`, `assertIsIterable()`, `assertIsNotIterable()` methods were introduced as replacements in PHPUnit 7.5. Ref: * https://github.com/sebastianbergmann/phpunit/blob/7.5.20/ChangeLog-7.5.md#750---2018-12-07 * sebastianbergmann/phpunit#3368

* Update Dockerfile - Removed PHP 5.5 & Added PHP 7.4 - PHP Redis Extension 4.3.0 is the latest version to support PHP 5 - Update Redis to 6.0.8 and enable TLS support for PHP 7 * Update .travis.yml - Update php-redis to 5.3.0 - Update redis-server to 6.0.8 * Fixes test failures - Use [assertIsArray](sebastianbergmann/phpunit#3368) method since PHPUnit v7.5 - Fixes AUTH error message changed since Redis v6 - `getMock()` is deprecated since PHPUnit v5.4 * Update Client.php - PHP Redis extension support TLS since [5.3.0](https://pecl.php.net/package/redis/5.3.0) - Fixes AUTH may not cleanup last error

As documented here: sebastianbergmann/phpunit#3368

As documented here: sebastianbergmann/phpunit#3368 Signed-off-by: Nathan Boiron <[email protected]>

…3368

PHPUnit 8 specializes several assertion methods: - sebastianbergmann/phpunit#3368 - sebastianbergmann/phpunit#3422 (comment)

See sebastianbergmann/phpunit#3368

* Add npm command to run tests in wp-env * Add a base env:tests-cmd script * Run composer install before running tests * Upgrade phpunit to 8.5 (latest 8.* minor release) * Void return type must now be specified in certain test methods See 'Return Type of Template Methods' at https://phpunit.de/announcements/phpunit-8.html * Remove calls to deprecated assertInternalType() See sebastianbergmann/phpunit#3368 * Don't generate test cache file * Don't use depreacated canonicalize parameter of assertEquals() * Using assertContains() with string haystacks is deprecated * Upgrade phpunit to 9.6 (latest 9.* minor release) * assertObjectHasAttribute() is deprecated in favour of assertObjectHasProperty() * assertRegExp() is deprecated in favour of assertMatchesRegularExpression() * Remove commented out code * Only run tests against nightly once * In GitHub actions, test under PHP 8.3 instead of 7.4 * Document jobs * In GitHub actions, also test under PHP 7.4 * Add some PHPUnit workflows with PHP 7.4 * Expand GitHub workflows matrix, instead of specifying each job --------- Co-authored-by: Jesús Amieiro Becerra <[email protected]>

See sebastianbergmann/phpunit#3368

sebastianbergmann added the type/enhancement A new idea that should be implemented label Oct 24, 2018

sebastianbergmann added this to the PHPUnit 7.5 milestone Oct 24, 2018

sebastianbergmann self-assigned this Oct 24, 2018

This was referenced Oct 24, 2018

Deprecate assertInternalType() and assertNotInternalType() #3369

Closed

Remove assertInternalType() and assertNotInternalType() #3370

Closed

sebastianbergmann closed this as completed in a406c85 Oct 29, 2018

Slamdunk mentioned this issue Dec 10, 2018

[PHPUnit] Add migration for 7.5 assertInternalType PHP-CS-Fixer/PHP-CS-Fixer#4144

Closed

SignpostMarv added a commit to daft-framework/daft-router that referenced this issue Dec 22, 2018

changing assertions re: sebastianbergmann/phpunit#3368

8e8b390

This was referenced Dec 28, 2018

[5.8] Replace deprecated phpunit <7.5.0 methods laravel/framework#26976

Closed

[5.7] Deprecation removal in tests laravel/framework#26987

Merged

TomasVotruba mentioned this issue Dec 31, 2018

[PHPUnit] foreach assertInternalType() to assertContainsOnly() rectorphp/rector#850

Closed

nelson6e65 added a commit to nelson6e65/php_nml that referenced this issue Jan 16, 2019

[tests] 🆙 Replace assertInternalType() assertion with specialized ones

0a806b2

sebastianbergmann/phpunit#3368

TiGR mentioned this issue Aug 29, 2019

Fix build for PHPUnit 9 Incenteev/hashed-asset-bundle#8

Merged

This was referenced Dec 1, 2019

Phpunit8 20191130 owncloud/core#36499

Closed

Refactor phpunit tests owncloud/core#36501

Merged

fritz-gerneth mentioned this issue Jan 4, 2021

[7.x] Add PHP8 to travis / PHP8 support prooph/event-store#413

Merged

8 tasks

jtojnar mentioned this issue Jan 10, 2021

ci: Add GitHub Actions workflow smottt/WideImage#21

Closed

Mopolo added a commit to Mopolo/laminas-soap that referenced this issue Jan 11, 2021

Use the new assertion method

0dddb29

As documented here: sebastianbergmann/phpunit#3368

Mopolo added a commit to Mopolo/laminas-soap that referenced this issue Jan 11, 2021

Use the new assertion method

dcdccb1

As documented here: sebastianbergmann/phpunit#3368 Signed-off-by: Nathan Boiron <[email protected]>

NicTorgersen added a commit to pindena/omnipay-tests that referenced this issue May 31, 2021

update base test assertions to comply with sebastianbergmann/phpunit#…

f3ea2ea

…3368

emteknetnz mentioned this issue Jul 23, 2021

[WIP] API Upgrade SapphireTest to work with phpunit 9 silverstripe/silverstripe-framework#10028

Merged

emteknetnz mentioned this issue Sep 26, 2021

PHPUnit 9+ (for PHP 8 support) silverstripe/silverstripe-framework#10019

Closed

93 tasks

ZVanoZ mentioned this issue Nov 4, 2021

qa: PhpUnit >= 9.0 Call to undefined method assertInternalType laminas/laminas-db#229

Open

This was referenced Feb 17, 2022

CTP-677 fixed phpunit tests aspark21/lsuce-block_quickmail#1

Closed

phpunit test fixes lsuonline/lsuce-block_quickmail#41

Closed

fixes for phpunit tests lsuonline/lsuce-block_quickmail#42

Closed

This was referenced Mar 18, 2022

Phpunit fixes aspark21/lsuce-block_quickmail#2

Closed

Phpunit fixes lsuonline/lsuce-block_quickmail#48

Merged

dawitengageiq pushed a commit to dawitengageiq/NLR that referenced this issue Sep 29, 2023

Shift assertion methods

392f19e

PHPUnit 8 specializes several assertion methods: - sebastianbergmann/phpunit#3368 - sebastianbergmann/phpunit#3422 (comment)

debaste pushed a commit to debaste/yii that referenced this issue Nov 25, 2023

Shift assertion methods

565f10e

PHPUnit 8 specializes several assertion methods: - sebastianbergmann/phpunit#3368 - sebastianbergmann/phpunit#3422 (comment)

psrpinto added a commit to psrpinto/GlotPress that referenced this issue Jan 10, 2024

Remove calls to deprecated assertInternalType()

04fc958

See sebastianbergmann/phpunit#3368

psrpinto added a commit to psrpinto/GlotPress that referenced this issue Jan 10, 2024

Remove calls to deprecated assertInternalType()

89837b4

See sebastianbergmann/phpunit#3368

psrpinto added a commit to psrpinto/GlotPress that referenced this issue Jan 10, 2024

Remove calls to deprecated assertInternalType()

d088c3b

See sebastianbergmann/phpunit#3368

psrpinto added a commit to psrpinto/GlotPress that referenced this issue Jan 10, 2024

Remove calls to deprecated assertInternalType()

92bce4e

See sebastianbergmann/phpunit#3368

psrpinto added a commit to psrpinto/GlotPress that referenced this issue Jan 10, 2024

Remove calls to deprecated assertInternalType()

ddfa196

See sebastianbergmann/phpunit#3368

jlherren mentioned this issue Apr 10, 2024

Incorrect behavior of AssertCompareToSpecificMethodRector rectorphp/rector#8593

Closed

phpclub mentioned this issue Jun 7, 2024

PHP 8.3 koseven/koseven#471

Open

adamfranco added a commit to middlebury/coursecatalog that referenced this issue Aug 8, 2024

#62: Fix calls to deprecated phpunit assertions.

80064fd

See sebastianbergmann/phpunit#3368

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement specialized alternatives to assertInternalType() and assertNotInternalType() #3368

Implement specialized alternatives to assertInternalType() and assertNotInternalType() #3368

sebastianbergmann commented Oct 24, 2018 •

edited

Loading

keradus commented Oct 25, 2018

TomasVotruba commented Dec 31, 2018

glensc commented Feb 9, 2019

sebastianbergmann commented Feb 9, 2019

glensc commented Feb 9, 2019

nelson6e65 commented Feb 9, 2019

JeroenDeDauw commented Feb 24, 2020

nelson6e65 commented Mar 1, 2020 •

edited

Loading

JeroenDeDauw commented Mar 1, 2020 •

edited

Loading

joelmellon commented Mar 26, 2020 •

edited

Loading

Implement specialized alternatives to assertInternalType() and assertNotInternalType() #3368

Implement specialized alternatives to assertInternalType() and assertNotInternalType() #3368

Comments

sebastianbergmann commented Oct 24, 2018 • edited Loading

keradus commented Oct 25, 2018

TomasVotruba commented Dec 31, 2018

glensc commented Feb 9, 2019

sebastianbergmann commented Feb 9, 2019

glensc commented Feb 9, 2019

nelson6e65 commented Feb 9, 2019

JeroenDeDauw commented Feb 24, 2020

nelson6e65 commented Mar 1, 2020 • edited Loading

JeroenDeDauw commented Mar 1, 2020 • edited Loading

joelmellon commented Mar 26, 2020 • edited Loading

sebastianbergmann commented Oct 24, 2018 •

edited

Loading

nelson6e65 commented Mar 1, 2020 •

edited

Loading

JeroenDeDauw commented Mar 1, 2020 •

edited

Loading

joelmellon commented Mar 26, 2020 •

edited

Loading