-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.x] Add PHP8 to travis / PHP8 support #413
Conversation
This reverts commit d93dda8.
Maybe we should switch to GitHub actions. |
Co-authored-by: Jáchym Toušek <[email protected]>
With PHP8 not working on Travis there is one apparent problem - other dependencies need to support PHP8 too. For the |
I see no problem to increase the minimum PHP version if needed. Maybe rector can be used to make the code automatically compatible if needed. But indeed, some work is needed. |
Bump the minor version and make it a 7.5 version / branch then? |
We already have version 7.5, so it will be 7.6. What do you think @codeliner @prolic ? Should we also increase the PHP minimum version to 7.4? I see no reason to support PHP 7.3 anymore in this new version. |
@@ -24,7 +24,7 @@ | |||
"minimum-stability": "dev", | |||
"prefer-stable": true, | |||
"require": { | |||
"php": "^7.1", | |||
"php": "^7.1 || ^8.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we set PHP minimum version to ^7.4
for the new minor version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7.3 is still supported until end of next year. PHPUnit 9 supports 7.3 and 8 . Any specific reason to jump to 7.4 right away?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, we can stick to PHP 7.3, because we don‘t want to use new features.
good for me |
Inherently this is blocked by prooph/php-cs-fixer-config#8 / PHP-CS to support PHP8. |
Note that php-cs-fixer (while it's not entirely ready to handle all PHP 8 features) no longer blocks installation under php 8. So in my opinion prooph/php-cs-fixer-config#8 can be merged now. |
I've updated prooph/php-cs-fixer-config#8 to support PHP |
Awesome. I'll update the prooph packages then :) |
This should be good for review now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome, just 2 minor notes.
|---------|------------|---------------|---------------| | ||
| 5.x | EOL | \>= 5.5 | EOL | | ||
| 6.x | Maintained | \>= 5.5 | 3 Dec 2017 | | ||
| 7.5.x | Latest | \>= 7. | active | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still requires 7.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took care of this myself.
Travis is currently missing the PHP 8 option ( https://travis-ci.community/t/php-8-0-missing/10132/17 ) but should be available next weekChanges:
ProphesizeTrait
,prophesize
integration has been moved into its own packagephpspec/prophecy-phpunit
assertInternalType()
with new assertions ( old ones have been removed )assertRegExp
is deprecated and replaced@medium
that were running longer than 1 second and thus being stoppedat
deprecation warnings in phpunit