Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark a test as risky that does not execute the code it wants to test #1899

Closed
sebastianbergmann opened this issue Oct 6, 2015 · 4 comments
Closed

Mark a test as risky that does not execute the code it wants to test #1899

sebastianbergmann opened this issue Oct 6, 2015 · 4 comments
Labels
type/enhancement A new idea that should be implemented

Comments

@sebastianbergmann
Copy link
Owner

A test that has a @covers c::m annotation, for instance, should be marked as risky when the c::m() method is not executed.
@sebastianbergmann sebastianbergmann added the type/enhancement A new idea that should be implemented label Oct 6, 2015
@sebastianbergmann
Copy link
Owner Author

Related to sebastianbergmann/php-code-coverage#234

@sebastianbergmann sebastianbergmann added this to the PHPUnit 5.2 milestone Oct 7, 2015
@sebastianheuer
Copy link
Contributor

@sebastianbergmann Should this behaviour be added to the --strict-coverage flag? Or should tests always be marked as risky in this case?

@sebastianbergmann
Copy link
Owner Author

It should be added to the --strict-coverage flag.

sebastianbergmann added a commit that referenced this issue Jan 12, 2016
@sebastianbergmann
Update documentation for #1899
8f4ea63
sebastianbergmann added a commit that referenced this issue Jan 12, 2016
@sebastianbergmann
Rename configuration setting for #1899
de20c60
@sebastianbergmann
Copy link
Owner Author

Reverted 580f715 until sebastianbergmann/php-code-coverage#420 is fixed.

@sebastianbergmann sebastianbergmann removed this from the PHPUnit 5.2 milestone Feb 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement A new idea that should be implemented
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebastianbergmann @sebastianheuer