-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for unexecuted covered or used code is too strict #420
Comments
I started to work on this in 1cedd8b. This should work unless the sourcecode file of the code unit to be covered or used has not been loaded at all. In that case https://github.com/sebastianbergmann/code-unit-reverse-lookup does not yield a useful result. All things considered, this approach is rather stupid. PHPUnit turns code unit information ( It might be best for PHPUnit to pass lists of code units (from |
@belanur We missed the opportunity of the PHPUnit Code Sprint to discuss this. @spriebsch just reminded me that this still does not work. Will try to look into it but any help appreciated. |
Updated the initial work done in March 2016 to the state of I will probably do what I thought about in #420 (comment), though. |
The implementation of #234 in 168eaf4 is too strict. When
@covers Foo::bar
is used then the current implementation expects all lines of code inFoo::bar()
to be executed when instead it should only expect one line of code inFoo::bar()
to be executed.The text was updated successfully, but these errors were encountered: