Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Uninitialized string offset -1 warning #119

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Oct 30, 2024

closes #118

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (df95a6e) to head (2c3940e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #119   +/-   ##
=========================================
  Coverage     99.00%   99.00%           
- Complexity      140      142    +2     
=========================================
  Files            15       15           
  Lines           400      402    +2     
=========================================
+ Hits            396      398    +2     
  Misses            4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nuernbergerA
Copy link

can confirm that this fixes it

@bastienho
Copy link

The patch works for me.

Thank you for the alacrity

@xabbuh
Copy link

xabbuh commented Oct 30, 2024

I can confirm that the patch fixes failures that were caused by 6.2.0 on the Symfony test suite. 👍

@sebastianbergmann sebastianbergmann merged commit 5a96656 into sebastianbergmann:main Oct 31, 2024
8 checks passed
@sebastianbergmann sebastianbergmann changed the title Fix "Uninitialized string offset -1" warning Fix Uninitialized string offset -1 warning Oct 31, 2024
@staabm staabm deleted the warn branch October 31, 2024 07:49
@staabm
Copy link
Contributor Author

staabm commented Oct 31, 2024

In phpstan/phpstan-src#3594 I am working on a PHPStan fix, so such errors will be reported by static analysis the next time before we release

SnakeCharm3r pushed a commit to SnakeCharm3r/comparator that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Warning] Uninitialized string offset -1 at src/ScalarComparator.php:139
5 participants