Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report invalid string offsets #3594

Open
wants to merge 5 commits into
base: 2.0.x
Choose a base branch
from

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Oct 31, 2024

@staabm staabm force-pushed the invalid-string-offsets branch 2 times, most recently from 4da3b92 to 0d2e494 Compare October 31, 2024 09:09
@staabm staabm marked this pull request as ready for review October 31, 2024 09:16
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

conf/bleedingEdge.neon Outdated Show resolved Hide resolved
@staabm staabm force-pushed the invalid-string-offsets branch 2 times, most recently from ad6d064 to cde20cd Compare November 5, 2024 21:03
@@ -3,3 +3,4 @@ parameters:
bleedingEdge: true
skipCheckGenericClasses!: []
stricterFunctionMap: true
reportPossiblyNonexistentStringOffset: true
Copy link
Contributor Author

@staabm staabm Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be enabled by default instead of using bleeding edge on 2.x, depending on how we decide here:
#3584 (comment)

@staabm staabm force-pushed the invalid-string-offsets branch from cde20cd to a3b8bdf Compare November 17, 2024 17:40
@clxmstaab clxmstaab force-pushed the invalid-string-offsets branch from a3b8bdf to c886a22 Compare December 20, 2024 09:15
@clxmstaab clxmstaab force-pushed the invalid-string-offsets branch from c886a22 to 08359ca Compare December 20, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report invalid string offsets
3 participants