Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve column values from state object #441

Merged
merged 9 commits into from
Nov 15, 2021

Commits on Nov 12, 2021

  1. Dynamic view column changes

    Refactor course instance table to obtain the default list of columns
    from a state value rather than a hard-coded list of columns
    Robert Main committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    95ea204 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. Add meetings column to default view

    The lack of a "meetings" column in the default view meant that the
    meeting modal integration tests were failing as they were expecting an
    "Edit Meeting" button to be visible. Since the meetings column was not
    visible, this was not the case and the tests thusly failed.
    
    This commit adds the meetings column into the default view to fix these
    breaking tests
    Robert Main committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    a84ae36 View commit details
    Browse the repository at this point in the history
  2. Add notes as optional column

    Going by the previous course planner, `notes` is an optional column
    Robert Main committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    c8b6481 View commit details
    Browse the repository at this point in the history
  3. Switch HTMLInputElement to HTMLSelectElement

    Robert Main committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    8e02202 View commit details
    Browse the repository at this point in the history
  4. Remove unnecessary spread operator from component parameter

    Since this expression just returns an array, we don't need the spread operator
    here
    Robert Main committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    f20c132 View commit details
    Browse the repository at this point in the history
  5. Wrap dropdown in <VerticalSpace> for consistency with other pages

    Other pages (such as `FacultyAdmin` and `CourseAdmin`) all use the
    `VerticalSpace` component for providing vertical space around the page
    content
    Robert Main committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    275ee8d View commit details
    Browse the repository at this point in the history
  6. Remove waitForElement from test case

    Aside from being deprecated in later versions(
    testing-library/dom-testing-library#416) it's also
    not needed here, as we can just return `findByDisplayValue` directly
    Robert Main committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    1e3f86d View commit details
    Browse the repository at this point in the history
  7. Remove unnecessary type cast

    The type can automatically be inferred from `defaultView` and usage of
    `T as Type` can actually interfere with other type checking done by
    TypeScript.
    Robert Main committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    0504b19 View commit details
    Browse the repository at this point in the history
  8. Re-order imports for eslint

    Robert Main committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    051ae02 View commit details
    Browse the repository at this point in the history