-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrieve column values from state object #441
Commits on Nov 12, 2021
-
Refactor course instance table to obtain the default list of columns from a state value rather than a hard-coded list of columns
Robert Main committedNov 12, 2021 Configuration menu - View commit details
-
Copy full SHA for 95ea204 - Browse repository at this point
Copy the full SHA 95ea204View commit details
Commits on Nov 15, 2021
-
Add meetings column to default view
The lack of a "meetings" column in the default view meant that the meeting modal integration tests were failing as they were expecting an "Edit Meeting" button to be visible. Since the meetings column was not visible, this was not the case and the tests thusly failed. This commit adds the meetings column into the default view to fix these breaking tests
Robert Main committedNov 15, 2021 Configuration menu - View commit details
-
Copy full SHA for a84ae36 - Browse repository at this point
Copy the full SHA a84ae36View commit details -
Going by the previous course planner, `notes` is an optional column
Robert Main committedNov 15, 2021 Configuration menu - View commit details
-
Copy full SHA for c8b6481 - Browse repository at this point
Copy the full SHA c8b6481View commit details -
Switch HTMLInputElement to HTMLSelectElement
Robert Main committedNov 15, 2021 Configuration menu - View commit details
-
Copy full SHA for 8e02202 - Browse repository at this point
Copy the full SHA 8e02202View commit details -
Remove unnecessary spread operator from component parameter
Since this expression just returns an array, we don't need the spread operator here
Robert Main committedNov 15, 2021 Configuration menu - View commit details
-
Copy full SHA for f20c132 - Browse repository at this point
Copy the full SHA f20c132View commit details -
Wrap dropdown in <VerticalSpace> for consistency with other pages
Other pages (such as `FacultyAdmin` and `CourseAdmin`) all use the `VerticalSpace` component for providing vertical space around the page content
Robert Main committedNov 15, 2021 Configuration menu - View commit details
-
Copy full SHA for 275ee8d - Browse repository at this point
Copy the full SHA 275ee8dView commit details -
Remove waitForElement from test case
Aside from being deprecated in later versions( testing-library/dom-testing-library#416) it's also not needed here, as we can just return `findByDisplayValue` directly
Robert Main committedNov 15, 2021 Configuration menu - View commit details
-
Copy full SHA for 1e3f86d - Browse repository at this point
Copy the full SHA 1e3f86dView commit details -
The type can automatically be inferred from `defaultView` and usage of `T as Type` can actually interfere with other type checking done by TypeScript.
Robert Main committedNov 15, 2021 Configuration menu - View commit details
-
Copy full SHA for 0504b19 - Browse repository at this point
Copy the full SHA 0504b19View commit details -
Robert Main committed
Nov 15, 2021 Configuration menu - View commit details
-
Copy full SHA for 051ae02 - Browse repository at this point
Copy the full SHA 051ae02View commit details