Retrieve column values from state object #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor course instance table to obtain the default list of columns from a state value rather than a hard-coded list of columns
jonseitz
requested changes
Nov 15, 2021
added 7 commits
November 15, 2021 10:53
The lack of a "meetings" column in the default view meant that the meeting modal integration tests were failing as they were expecting an "Edit Meeting" button to be visible. Since the meetings column was not visible, this was not the case and the tests thusly failed. This commit adds the meetings column into the default view to fix these breaking tests
Going by the previous course planner, `notes` is an optional column
Since this expression just returns an array, we don't need the spread operator here
Other pages (such as `FacultyAdmin` and `CourseAdmin`) all use the `VerticalSpace` component for providing vertical space around the page content
Aside from being deprecated in later versions( testing-library/dom-testing-library#416) it's also not needed here, as we can just return `findByDisplayValue` directly
The type can automatically be inferred from `defaultView` and usage of `T as Type` can actually interfere with other type checking done by TypeScript.
Codecov Report
@@ Coverage Diff @@
## develop #441 +/- ##
===========================================
- Coverage 97.82% 97.80% -0.02%
===========================================
Files 151 152 +1
Lines 2761 2785 +24
Branches 278 278
===========================================
+ Hits 2701 2724 +23
- Misses 26 27 +1
Partials 34 34
Continue to review full report at Codecov.
|
jonseitz
approved these changes
Nov 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
to change)
Checklist:
eslinton the codePriority:
Related Issues:
Fixes #437