feat(proxy): Adds NO_PROXY environment variable support #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomastaylor312
force-pushed
the
feat/no_proxy
branch
from
f06b677
to
b101ca1
Compare
|
The one thing I could use help with here is that if I don't use |
|
Just added a commit that manually constructs the proxy each time so as to avoid caching for tests. If that is not desired behavior, let me know what else I can do and I'll change it |
thomastaylor312
force-pushed
the
feat/no_proxy
branch
from
30064f1
to
d1ebc9b
Compare
|
@seanmonstar, I could definitely use this--can you take a look? |
thomastaylor312
force-pushed
the
feat/no_proxy
branch
from
d1ebc9b
to
1c7cb00
Compare
|
thank you, works like a charm ❤️ |
thomastaylor312
force-pushed
the
feat/no_proxy
branch
from
1c7cb00
to
3436f29
Compare
Adds support for loading from the `NO_PROXY` or `no_proxy` environment variables. This should make reqwest support the system proxy settings. Please note that I brought in one additional dependency in order to handle CIDR blocks in the no proxy settings. Closes seanmonstar#705
thomastaylor312
force-pushed
the
feat/no_proxy
branch
from
3436f29
to
cba33b3
Compare
seanmonstar
approved these changes
Jun 8, 2020
|
No problem! Thanks for the review |
This was referenced Jul 27, 2020
Nutomic
pushed a commit
to Nutomic/reqwest
that referenced
this pull request
Nov 7, 2024
) * feat(proxy): Adds NO_PROXY environment variable support Adds support for loading from the `NO_PROXY` or `no_proxy` environment variables. This should make reqwest support the system proxy settings. Please note that I brought in one additional dependency in order to handle CIDR blocks in the no proxy settings. Closes seanmonstar#705
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for loading from the
NO_PROXYorno_proxyenvironmentvariables. This should make reqwest support the system proxy settings.
Please note that I brought in one additional dependency in order to
handle CIDR blocks in the no proxy settings.
Closes #705