Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: support proxy exclusion for some endpoints #254

Closed
lucab opened this issue Mar 31, 2020 · 1 comment · Fixed by #334
Closed

http: support proxy exclusion for some endpoints #254

lucab opened this issue Mar 31, 2020 · 1 comment · Fixed by #334
Labels
kind/new-feature
Milestone
v0.0.13

Comments

@lucab
Copy link
Contributor

lucab commented Mar 31, 2020

Followup from coreos/fedora-coreos-tracker#379 (comment).

Zincati currently supports fetching HTTP content through proxies specified via environment variables. However, proxy configuration is applied to all HTTP requests. In some cases, it would helpful to exclude some endpoints which cannot be meaningfully fetched over proxies (e.g. localhost endpoint). At the moment the HTTP library reqwest that we are using does not support that.
In order to fix this, we should either:
@lucab lucab mentioned this issue Mar 31, 2020
Open
@lucab
Copy link
Contributor Author

lucab commented Jul 27, 2020

seanmonstar/reqwest#877 fixed this on the library side.

@lucab lucab added this to the vNext milestone Jul 27, 2020
@dependabot dependabot bot mentioned this issue Jul 27, 2020
Merged
@dependabot dependabot bot closed this as completed in #334 Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/new-feature
Projects
None yet
Milestone
v0.0.13
Development

Successfully merging a pull request may close this issue.

build(deps): bump reqwest from 0.10.6 to 0.10.7 coreos/zincati
1 participant
@lucab