Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#234] Encounter Time Modified Pruning Settings - Frontend #356

Merged
merged 2 commits into from
Apr 3, 2022
Merged

[#234] Encounter Time Modified Pruning Settings - Frontend #356

merged 2 commits into from
Apr 3, 2022

Conversation

seanhogunkim
Copy link
Collaborator

@seanhogunkim seanhogunkim commented Apr 3, 2022 •
edited
Loading

  • Added 'Manage Data' section to Settings page which contains pruning settings
  • Has date selector and Prune button
  • Popup upon confirming Prune to notify user of response
    image
  • Added pruneEncounters method to index.js, which calls the Prune endpoint created for the backend of this issue

@seanhogunkim seanhogunkim linked an issue Apr 3, 2022 that may be closed by this pull request
Encounter Time Modified Pruning Settings #234
Closed
3 tasks
@seanhogunkim seanhogunkim changed the title [#234] Auto Prune Settings - Frontend [#234] Encounter Pruning Settings - Frontend Apr 3, 2022
skwe902
skwe902 reviewed Apr 3, 2022
View reviewed changes
Copy link
Collaborator

@skwe902 skwe902 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! - all requirements have been met and Pruning is relative to time_updated field in Encounter. In the future a new issue could be created to be able to prune relative to encounter date.

@seanhogunkim seanhogunkim changed the title [#234] Encounter Pruning Settings - Frontend [#234] Encounter Time Modified Pruning Settings - Frontend Apr 3, 2022
bikkku
bikkku approved these changes Apr 3, 2022
View reviewed changes
Copy link
Collaborator

@bikkku bikkku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code looks clean and seems to be working fine.

@seanhogunkim seanhogunkim merged commit 5d93f9e into se701team3:main-a2 Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skwe902 skwe902 skwe902 left review comments

@bikkku bikkku bikkku approved these changes

@harristomy harristomy Awaiting requested review from harristomy

Assignees
No one assigned
Labels
team-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Encounter Time Modified Pruning Settings
3 participants
@seanhogunkim @bikkku @skwe902