Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encounter Time Modified Pruning Settings #234

Closed
3 tasks done
uoa-lchu090 opened this issue Mar 18, 2022 · 0 comments · Fixed by #356
Closed
3 tasks done

Encounter Time Modified Pruning Settings #234

uoa-lchu090 opened this issue Mar 18, 2022 · 0 comments · Fixed by #356
Assignees
@seanhogunkim
Labels
approved backend feature new feature to be added to codebase frontend future team-3

Comments

@uoa-lchu090
Copy link
Contributor

uoa-lchu090 commented Mar 18, 2022 •
edited by harristomy
Loading

Description

Add settings and functionality to automatically delete really old encounters, fully configurable by the user but there will be a maximum time where all encounters will be deleted to prevent bloat.

Acceptance Criteria

  • FE: Add a setting on the settings page for this feature
  • BE: Configure backend to auto delete encounters after they exceed a certain timestamp
  • BE: Implement pruning endpoint, where users can specify a date before which they want all encounters pruned.

Implementation details

One new API call for the settings page, deletion is completely backend.
Pruning is manual, users can select a date to prune before in the Settings page.
Pruning is relative to time_updated field in Encounter

Testing notes

Backend tests created to check if Encounters preceding prune data are correctly deleted

Future plans

If needed, can also create a pruning feature for encounter dates, instead of time_updated
@uoa-lchu090 uoa-lchu090 added feature new feature to be added to codebase backend future labels Mar 18, 2022
@seanhogunkim seanhogunkim self-assigned this Mar 26, 2022
@seanhogunkim seanhogunkim mentioned this issue Apr 2, 2022
Merged
seanhogunkim added a commit that referenced this issue Apr 2, 2022
@seanhogunkim
[#234] Auto Prune Settings (#343)
d0207d5 
* Added TTL for encounters of 1 year

* Pruning endpoint created.
Takes input of date which we want to prune before
TODO testing.

* Added test to check that encounters before prune date are deleted

* Fixed prune test to properly call api
@seanhogunkim seanhogunkim linked a pull request Apr 3, 2022 that will close this issue
[#234] Encounter Time Modified Pruning Settings - Frontend #356
Merged
@seanhogunkim seanhogunkim changed the title Auto Prune Settings Encounter Pruning Settings Apr 3, 2022
@seanhogunkim seanhogunkim changed the title Encounter Pruning Settings Encounter Time Modified Pruning Settings Apr 3, 2022
abis555 pushed a commit to abis555/Forgettable that referenced this issue Apr 5, 2022
@seanhogunkim @abis555
[se701team3#234] Auto Prune Settings (se701team3#343)
eabf03b 
* Added TTL for encounters of 1 year

* Pruning endpoint created.
Takes input of date which we want to prune before
TODO testing.

* Added test to check that encounters before prune date are deleted

* Fixed prune test to properly call api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanhogunkim seanhogunkim

Labels
approved backend feature new feature to be added to codebase frontend future team-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#234] Encounter Time Modified Pruning Settings - Frontend seanhogunkim/Forgettable
2 participants
@seanhogunkim @uoa-lchu090