Birthday reminders for Persons on your list #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eating new service functions
… birthday so cannot test in same way as previous tests
nzbasic
requested changes
Mar 31, 2022
forgettable-frontend/src/components/UpcomingBirthdaySummary/UpcomingBirthdaySummary.js
Outdated
Show resolved
Hide resolved
...le-frontend/src/components/UpcomingBirthdaySummary/__tests__/UpcomingBirthdaySummary.test.js
Outdated
Show resolved
Hide resolved
nzbasic
approved these changes
Mar 31, 2022
nzbasic
changed the title
abis555
pushed a commit
to abis555/Forgettable
that referenced
this pull request
Apr 2, 2022
* Created upcoming birthday summary and added card to main page * Updated date format and birthday api retrieval based on api spec * Finished adding component to home page properly utilising new api, creating new service functions * Wrote some static tests where possible (Dates are always changing for birthday so cannot test in same way as previous tests * Cleaned up code as per review changes, removed duplicate function, and fixed indentation * Removed service account json * Fixed test to ignore date
abis555
pushed a commit
to abis555/Forgettable
that referenced
this pull request
Apr 5, 2022
* Created upcoming birthday summary and added card to main page * Updated date format and birthday api retrieval based on api spec * Finished adding component to home page properly utilising new api, creating new service functions * Wrote some static tests where possible (Dates are always changing for birthday so cannot test in same way as previous tests * Cleaned up code as per review changes, removed duplicate function, and fixed indentation * Removed service account json * Fixed test to ignore date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished front end component for this issue as specified.
