Skip to content

Commit

Permalink
Birthday reminders for Persons on your list (se701team3#339)
Browse files Browse the repository at this point in the history
* Created upcoming birthday summary and added card to main page

* Updated date format and birthday api retrieval based on api spec

* Finished adding component to home page properly utilising new api, creating new service functions

* Wrote some static tests where possible (Dates are always changing for birthday so cannot test in same way as previous tests

* Cleaned up code as per review changes, removed duplicate function, and fixed indentation

* Removed service account json

* Fixed test to ignore date
  • Loading branch information
asok3781 authored and abis555 committed Apr 5, 2022
1 parent 945f93b commit c6a70b1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion forgettable-frontend/src/pages/home/Home.js
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ function Home() {
<div key={index + 'e'} className={classes.home_cardWrapper} onMouseOver={(event) => handlePersonHover(event, index)} onMouseOut={handleOnMouseOut}>
<Link to={`/person/${birthdayPerson._id}`} style={{textDecoration: 'none'}}>
<UpcomingBirthdaySummary
firstName={birthdayPerson.name}
name={birthdayPerson.name}
birthday={birthdayPerson.birthday}
img={birthdayPerson.image}
onClick={() => { }}
Expand Down

0 comments on commit c6a70b1

Please sign in to comment.