Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix frontend tests for CI #317

Merged
merged 13 commits into from
Mar 21, 2022
Merged

Fix frontend tests for CI #317

merged 13 commits into from
Mar 21, 2022

Conversation

rainasong
Copy link
Contributor

Fixed the following tests:

  • EncounterCard.test.js
  • PersonCard.test.js
  • NavBar.test.js
  • Index.test.js
  • EdiPerson.test.js

Should unblock #153

@hajineats hajineats linked an issue Mar 21, 2022 that may be closed by this pull request
Miscellaneous frontend bugs #319
Closed
5 tasks
hajineats
hajineats approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@hajineats hajineats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lin8231
lin8231 approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@lin8231 lin8231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOOOO Thanks for fixing this

@rainasong rainasong merged commit 1291f39 into se701team3:main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hajineats hajineats hajineats approved these changes

@lin8231 lin8231 lin8231 approved these changes

Assignees
No one assigned
Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Miscellaneous frontend bugs
3 participants
@rainasong @lin8231 @hajineats