Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous frontend bugs #319

Closed
5 tasks done
hajineats opened this issue Mar 21, 2022 · 1 comment · Fixed by #318 or #317
Closed
5 tasks done

Miscellaneous frontend bugs #319

hajineats opened this issue Mar 21, 2022 · 1 comment · Fixed by #318 or #317
Labels
approved bug Something isn't working frontend testing

Comments

@hajineats
Copy link
Contributor

hajineats commented Mar 21, 2022 •
edited
Loading

Description

Bunch of frontend bugs that need to be fixed.

  • different components on different pages have different fields missing/incorrect (because unmarshalling inconsistency)
  • social media not working
  • date prop has an issue
  • Bunch of tests not passing

Acceptance Criteria

  • Unmarshall data a unified way so it's consistent for every page
  • Get social media link to show
  • Added unmarshaller for data
  • Fixed date prop type issue
  • Make sure all the tests pass
    • EncounterCard.test.js
    • PersonCard.test.js
    • NavBar.test.js
    • Index.test.js
    • EdiPerson.test.js

Implementation details

n/a

Testing notes

n/a
@hajineats hajineats added bug Something isn't working frontend testing labels Mar 21, 2022
This was linked to pull requests Mar 21, 2022
Fix a number of frontend bugs #318
Merged
Fix frontend tests for CI #317
Merged
@jimwang6012
Copy link
Contributor

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved bug Something isn't working frontend testing
Projects
None yet
Milestone
No milestone
3 participants
@AdamAWiener @jimwang6012 @hajineats