Revert "Font Issue on M1 Mac Big Sur" #119
Conversation
|
Click here to submit a new iteration when this PR is ready for review. See this repository's contribution guide for more information. |
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
=========================================
Coverage 72.15% 72.15%
Complexity 399 399
=========================================
Files 70 70
Lines 1232 1232
Branches 125 125
=========================================
Hits 889 889
Misses 311 311
Partials 32 32 Continue to review full report at Codecov.
|
|
@kouyk This is an automatic git revert, correct? And this requires us to release a new version, right? |
Yes, that's right. I reverted through github, I might need to do some manual fixes to resolve the conflicts now that the help window PR has been merged in. |
This reverts commit 9a46153, which was aimed at sidestepping se-edu#105. A better solution has been identified which made the current fix redundant while introducing path issues that are not obvious, see se-edu#111 for more details.
kouyk
force-pushed
the
revert-106-105-font-issue-on-m1-mac
branch
from
2ec9dbc to
8971ba4
Compare
v1@kouyk submitted v1 for review. Checkout this PR version locallygit fetch https://github.com/se-edu/addressbook-level3.git refs/pr/119/1/head:BRANCHNAMEwhere |
|
Thanks very much for the fix @kouyk |
Reverts #106 to resolve #111.
The original PR aimed to side step the garbled fonts on M1 Mac devices by embedding another font of our choice. One upside and unintended consequence is that fonts are consistent across the various OS regardless of font availability, helping to avoid any potential UI bugs such as text being cut off prematurely etc. However, this does bring about unnecessary complication as more resources are being loaded into the application, such as the one surfaced here, mandating the use of even more workarounds such as the one referenced in #111.
The M1 MacOS issue was eventually resolved through the use of an alternative OpenJDK build that happened to have native M1 binaries as well. Given that the issue originated from OpenJDK rather than AB3 itself, it no longer make sense for the "fix" to be applied to AB3, which seems to cause more trouble than it is worth. Given that most students are fresh to JavaFX, the additional complication does not seem warranted.