-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font issue on M1 Mac Big Sur #105
Comments
@se-edu/tech-team-level1 can investigate this one, especially if you are a Mac user? |
I'm using mac but intel chip and it works fine, might be something to do with the new M1 chip? |
Perhaps installing the missing font might help? Is that possible? e.g., is the missing font available for installing? |
Java should automatically find a fallback font according to my testing on Ubuntu, whereby I did remove all Windows specific fonts but the application still displays properly. This looks like an encoding issue more than font issue. |
Thanks for the inputs so far guys. Feel free to post suggestions (if any) in that issue as well. |
Someone fixed the problem partially by installing one missing font nus-cs2103-AY2122S1/forum#66 (comment) He wants to know what other fonts are being used. |
I took a look at the font that he downloaded. Apparently, the font that he downloaded contains the He needs to additionally download |
Guys, shall we update AB3 to use a more common font? We can do that right now if we move fast, given the current batch hasn't started using AB3 code yet. Anyone up for submitting a PR? |
I can submit a PR, shall we use Arial as the default font? |
Arial does look feasible, but on Ubuntu and other open source distributions Arial is not available by default. Would it be better for us to embed an open license font like Noto instead? Here is a list of fonts on Pop! OS 21.04 (a derivative distro from Ubuntu 21.04), see fonts.txt |
Seems like Noto only has Bold and Regular styles, whereas Open Sans has Light, SemiBold and Bold fonts (those that are being used by AB3). Perhaps Open Sans might be a good font to use. |
Noto Sans does have the other font weights as well. See here. |
In light of the recent investigations that revealed the cause of font issues on M1 Macs, not only has this issue been resolved, the proposed fixed has also been made somewhat redundant. Nevertheless, the switch to Open Sans did make the fonts consistent across all platforms without having to rely upon the running system to select a fallback font. Should actions be taken to update the commit for the font change? |
@kouyk Do you mean, change the commit message? |
Yes, since it does contain information that is no longer correct/relevant. |
I guess we can, but that requires a force push -- probably should delay till this semester is over? |
In this case should a new issue be opened to serve as a reminder? |
Good idea @kouyk Please go ahead. |
This reverts commit 9a46153, which was aimed at sidestepping se-edu#105. A better solution has been identified which made the current fix redundant while introducing path issues that are not obvious, see se-edu#111 for more details.
AY2425S1-CS2103T-W14-3#119) This reverts commit 0075d32, which was aimed at sidestepping se-edu/addressbook-level3#105. A better solution has been identified which made the current fix redundant while introducing path issues that are not obvious, see se-edu/addressbook-level3#111 for more details.
See nus-cs2103-AY2122S1/forum#66
The text was updated successfully, but these errors were encountered: