Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font issue on M1 Mac Big Sur #105

Closed
damithc opened this issue Aug 22, 2021 · 18 comments · Fixed by #106
Closed

Font issue on M1 Mac Big Sur #105

damithc opened this issue Aug 22, 2021 · 18 comments · Fixed by #106

Comments

@damithc
Copy link
Contributor

damithc commented Aug 22, 2021

See nus-cs2103-AY2122S1/forum#66

@damithc
Copy link
Contributor Author

damithc commented Aug 22, 2021

@se-edu/tech-team-level1 can investigate this one, especially if you are a Mac user?

@RuiFengg
Copy link
Contributor

I'm using mac but intel chip and it works fine, might be something to do with the new M1 chip?

@damithc
Copy link
Contributor Author

damithc commented Aug 23, 2021

Perhaps installing the missing font might help? Is that possible? e.g., is the missing font available for installing?

@kouyk
Copy link
Contributor

kouyk commented Aug 23, 2021

Java should automatically find a fallback font according to my testing on Ubuntu, whereby I did remove all Windows specific fonts but the application still displays properly. This looks like an encoding issue more than font issue.

@damithc
Copy link
Contributor Author

damithc commented Aug 23, 2021

Thanks for the inputs so far guys. Feel free to post suggestions (if any) in that issue as well.

@damithc
Copy link
Contributor Author

damithc commented Aug 23, 2021

Someone fixed the problem partially by installing one missing font nus-cs2103-AY2122S1/forum#66 (comment)

He wants to know what other fonts are being used.

@JinHao-L
Copy link
Contributor

I took a look at the font that he downloaded. Apparently, the font that he downloaded contains the Segeo UI font (which is used by cell_small_label).

He needs to additionally download Segeo UI Light and Segeo UI Semibold specifically to fix the other texts (from what I see in the DarkTheme.css file)

@damithc
Copy link
Contributor Author

damithc commented Aug 23, 2021

Guys, shall we update AB3 to use a more common font? We can do that right now if we move fast, given the current batch hasn't started using AB3 code yet. Anyone up for submitting a PR?

@ernestlim8
Copy link
Contributor

I can submit a PR, shall we use Arial as the default font?

@kouyk
Copy link
Contributor

kouyk commented Aug 23, 2021

Arial does look feasible, but on Ubuntu and other open source distributions Arial is not available by default. Would it be better for us to embed an open license font like Noto instead?

Here is a list of fonts on Pop! OS 21.04 (a derivative distro from Ubuntu 21.04), see fonts.txt

@ernestlim8
Copy link
Contributor

Seems like Noto only has Bold and Regular styles, whereas Open Sans has Light, SemiBold and Bold fonts (those that are being used by AB3). Perhaps Open Sans might be a good font to use.

@kouyk
Copy link
Contributor

kouyk commented Aug 23, 2021

Seems like Noto only has Bold and Regular styles, whereas Open Sans has Light, SemiBold and Bold fonts (those that are being used by AB3). Perhaps Open Sans might be a good font to use.

Noto Sans does have the other font weights as well. See here.

@kouyk
Copy link
Contributor

kouyk commented Sep 15, 2021

In light of the recent investigations that revealed the cause of font issues on M1 Macs, not only has this issue been resolved, the proposed fixed has also been made somewhat redundant. Nevertheless, the switch to Open Sans did make the fonts consistent across all platforms without having to rely upon the running system to select a fallback font. Should actions be taken to update the commit for the font change?

@damithc
Copy link
Contributor Author

damithc commented Sep 15, 2021

Should actions be taken to update the commit for the font change?

@kouyk Do you mean, change the commit message?

@kouyk
Copy link
Contributor

kouyk commented Sep 15, 2021

@kouyk Do you mean, change the commit message?

Yes, since it does contain information that is no longer correct/relevant.

@damithc
Copy link
Contributor Author

damithc commented Sep 15, 2021

Yes, since it does contain information that is no longer correct/relevant.

I guess we can, but that requires a force push -- probably should delay till this semester is over?

@kouyk
Copy link
Contributor

kouyk commented Sep 15, 2021

I guess we can, but that requires a force push -- probably should delay till this semester is over?

In this case should a new issue be opened to serve as a reminder?

@damithc
Copy link
Contributor Author

damithc commented Sep 15, 2021

In this case should a new issue be opened to serve as a reminder?

Good idea @kouyk Please go ahead.

kouyk added a commit to kouyk/addressbook-level3 that referenced this issue Jan 2, 2022
This reverts commit 9a46153, which was aimed
at sidestepping se-edu#105. A better solution has been
identified which made the current fix redundant while introducing path issues
that are not obvious, see se-edu#111 for more details.
damithc pushed a commit that referenced this issue Jan 13, 2022
This reverts commit 9a46153, which was aimed
at sidestepping #105. A better solution has been
identified which made the current fix redundant while introducing path issues
that are not obvious, see #111 for more details.
starchypotatocode pushed a commit to starchypotatocode/tp that referenced this issue Dec 21, 2024
AY2425S1-CS2103T-W14-3#119)

This reverts commit 0075d32, which was aimed
at sidestepping se-edu/addressbook-level3#105. A better solution has been
identified which made the current fix redundant while introducing path issues
that are not obvious, see se-edu/addressbook-level3#111 for more details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants