Add cell line annotation #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zethson
reviewed
Dec 28, 2022
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
2. add statement for downloading
yugeji
reviewed
Jan 23, 2023
yugeji
reviewed
Jan 23, 2023
yugeji
reviewed
Jan 23, 2023
2. add getinfo function 3. add bulk rna expression annotation
2. make bulk rna part more efficient
Zethson
reviewed
Feb 21, 2023
Zethson
reviewed
Feb 21, 2023
2. finish bulk rna / ccle / protein expression data annotation
Zethson
requested changes
Mar 12, 2023
There was a problem hiding this comment.
Thank you very much! This looks nice.
Lots of minor comments.
I think that we should rename the MetaData class to CellLineMetaData or something like this. I thought that we could have several classes that subclass the MetaData or something but this doesn't really work here. These classes should however still be in the metadata module. Could you please change this and also have this reflected in the docs?
Change downloading description Co-authored-by: Lukas Heumos <[email protected]>
Change downloading description Co-authored-by: Lukas Heumos <[email protected]>
Change downloading description Co-authored-by: Lukas Heumos <[email protected]>
Change downloading description Co-authored-by: Lukas Heumos <[email protected]>
remove unused code Co-authored-by: Lukas Heumos <[email protected]>
Change downloading description Co-authored-by: Lukas Heumos <[email protected]>
Change downloading description Co-authored-by: Lukas Heumos <[email protected]>
Change downloading description Co-authored-by: Lukas Heumos <[email protected]>
Co-authored-by: Lukas Heumos <[email protected]>
Co-authored-by: Lukas Heumos <[email protected]>
2. docstring
2. add another cell line metadata
… wxicu/development
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
docsis updatedDescription of changes
Add a class called
MetaData()for tooling with the functionannotate_cell_linesto annotate the cell line meta data.Technical details
Additional context