Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cookiecutter variable for project repo in conf.py #278

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Use cookiecutter variable for project repo in conf.py #278

merged 2 commits into from
Apr 25, 2024

Conversation

Zethson
Copy link
Member

@Zethson Zethson commented Apr 23, 2024

No description provided.

@scverse-bot scverse-bot mentioned this pull request Apr 23, 2024
Closed
@github-actions GitHub Actions
Copy link

A PR has been generated to the instance repo:
scverse/cookiecutter-scverse-instance#122

You can check out the PR to preview your changes
in an instance of the cookiecutter template. The PR will be kept in sync with
this PR automatically.

@Zethson Zethson requested a review from flying-sheep April 24, 2024 07:15
@flying-sheep flying-sheep merged commit c29afb3 into main Apr 25, 2024
7 checks passed
@flying-sheep flying-sheep deleted the fix/project_repo_conf_py branch April 25, 2024 14:01
This was referenced May 21, 2024
Open
Merged
Open
Open
Closed
Merged
Open
Merged
Open
Merged
Merged
Open
Open
Open
Closed
Open
Merged
Merged
Open
Open
Open
Open
This was referenced May 21, 2024
Open
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Closed
Merged
Closed
Closed
Merged
Merged
Open
Merged
Open
Open
Open
Open
Open
@flying-sheep
Copy link
Member

Oof actually I think this isn’t correct.

html_context["github_repo"] should only contain the repo name, not the URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flying-sheep flying-sheep flying-sheep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zethson @flying-sheep