Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support EIP-3651 (Warm COINBASE) with shanghai feature #500

Merged
merged 1 commit into from
May 15, 2023
Merged

Support EIP-3651 (Warm COINBASE) with shanghai feature #500

merged 1 commit into from
May 15, 2023

Conversation

silathdiir
Copy link

@silathdiir silathdiir commented May 8, 2023 •
edited
Loading

Reference geth Prepare function.

Description

Add a new access-list write for coinbase to begin_tx.

Type of change

  • New feature (non-breaking change which adds functionality)

Issue

Upstream issue privacy-scaling-explorations#1367

Test

Test cases of BeginTxGadget could succeed to run with or without shanghai feature.
Enable ShanghaiTime debug output of geth-utils when run with shanghai feature.

cargo test -- --nocapture begin_tx_

cargo test --features shanghai -- --nocapture begin_tx_

@silathdiir silathdiir requested a review from lispc May 8, 2023 00:54
@silathdiir silathdiir mentioned this pull request May 8, 2023
Merged
7 tasks
@lispc
Copy link

lispc commented May 8, 2023 •
edited
Loading

the warm coin base bus mapping part and circuit part seem correct.

but we may need to make some changes to the geth-util/external-tracer.

instead of create chainConfig := params.ChainConfig inside golang, what about create this struct in rust and pass it as a json string to golang?
then when feature=shanghai, set params.ChainConfig.ShanghaiTime = 0.

@silathdiir silathdiir marked this pull request as draft May 9, 2023 00:18
@silathdiir silathdiir mentioned this pull request May 9, 2023
Closed
7 tasks
Base automatically changed from feat/shanghai to develop May 9, 2023 03:11
@silathdiir silathdiir force-pushed the shanghai/eip-3651-warm-coinbase branch from c99a821 to 8dd448e Compare May 9, 2023 13:26
@silathdiir silathdiir marked this pull request as ready for review May 10, 2023 01:11
@lispc lispc merged commit f90e262 into develop May 15, 2023
@lispc lispc deleted the shanghai/eip-3651-warm-coinbase branch May 15, 2023 08:34
@silathdiir silathdiir restored the shanghai/eip-3651-warm-coinbase branch May 22, 2023 07:20
@silathdiir silathdiir mentioned this pull request May 22, 2023
Merged
1 task
github-merge-queue bot pushed a commit to privacy-scaling-explorations/zkevm-circuits that referenced this pull request Jun 2, 2023
@silathdiir @lispc
feat: add shanghai feature and make CI pass with Shanghai geth trac…
de9f845 
…es (#1424)

### Description

1. Add Shanghai related fields to chain config in geth-utils.

2. EIP-3651 (Warm COINBASE): add a new access-list write for coinbase to
Begin TX.

3. Part of EIP-3860 (Limit and meter initcode): only add gas cost of
init code to Begin TX (missing gas cost changes in Create and OOG
Create).

### Issue Link

Issue
#1362

Local related PRs:
scroll-tech#497
scroll-tech#500
scroll-tech#507

Reference previous PR:
#1361

### Type of change

- [x] Breaking change (fix or feature that would cause existing
functionality to not work as expected)

### How Has This Been Tested?

Unit test cases of CI could pass with Shanghai geth traces.

---------

Co-authored-by: Zhang Zhuo <[email protected]>
@KimiWu123 KimiWu123 mentioned this pull request Jul 7, 2023
Closed
johntaiko pushed a commit to johntaiko/zkevm-circuits that referenced this pull request Aug 20, 2023
@silathdiir @lispc @johntaiko
feat: add shanghai feature and make CI pass with Shanghai geth trac…
b3edabc 
…es (privacy-scaling-explorations#1424)

1. Add Shanghai related fields to chain config in geth-utils.

2. EIP-3651 (Warm COINBASE): add a new access-list write for coinbase to
Begin TX.

3. Part of EIP-3860 (Limit and meter initcode): only add gas cost of
init code to Begin TX (missing gas cost changes in Create and OOG
Create).

Issue
privacy-scaling-explorations#1362

Local related PRs:
scroll-tech#497
scroll-tech#500
scroll-tech#507

Reference previous PR:
privacy-scaling-explorations#1361

- [x] Breaking change (fix or feature that would cause existing
functionality to not work as expected)

Unit test cases of CI could pass with Shanghai geth traces.

---------

Co-authored-by: Zhang Zhuo <[email protected]>
johntaiko pushed a commit to johntaiko/zkevm-circuits that referenced this pull request Aug 20, 2023
@silathdiir @lispc @johntaiko
feat: add shanghai feature and make CI pass with Shanghai geth trac…
e3451a5 
…es (privacy-scaling-explorations#1424)

1. Add Shanghai related fields to chain config in geth-utils.

2. EIP-3651 (Warm COINBASE): add a new access-list write for coinbase to
Begin TX.

3. Part of EIP-3860 (Limit and meter initcode): only add gas cost of
init code to Begin TX (missing gas cost changes in Create and OOG
Create).

Issue
privacy-scaling-explorations#1362

Local related PRs:
scroll-tech#497
scroll-tech#500
scroll-tech#507

Reference previous PR:
privacy-scaling-explorations#1361

- [x] Breaking change (fix or feature that would cause existing
functionality to not work as expected)

Unit test cases of CI could pass with Shanghai geth traces.

---------

Co-authored-by: Zhang Zhuo <[email protected]>
johntaiko pushed a commit to johntaiko/zkevm-circuits that referenced this pull request Aug 20, 2023
@silathdiir @lispc @johntaiko
feat: add shanghai feature and make CI pass with Shanghai geth trac…
2196cf8 
…es (privacy-scaling-explorations#1424)

1. Add Shanghai related fields to chain config in geth-utils.

2. EIP-3651 (Warm COINBASE): add a new access-list write for coinbase to
Begin TX.

3. Part of EIP-3860 (Limit and meter initcode): only add gas cost of
init code to Begin TX (missing gas cost changes in Create and OOG
Create).

Issue
privacy-scaling-explorations#1362

Local related PRs:
scroll-tech#497
scroll-tech#500
scroll-tech#507

Reference previous PR:
privacy-scaling-explorations#1361

- [x] Breaking change (fix or feature that would cause existing
functionality to not work as expected)

Unit test cases of CI could pass with Shanghai geth traces.

---------

Co-authored-by: Zhang Zhuo <[email protected]>
johntaiko pushed a commit to johntaiko/zkevm-circuits that referenced this pull request Aug 20, 2023
@silathdiir @lispc @johntaiko
feat: add shanghai feature and make CI pass with Shanghai geth trac…
46c5125 
…es (privacy-scaling-explorations#1424)

1. Add Shanghai related fields to chain config in geth-utils.

2. EIP-3651 (Warm COINBASE): add a new access-list write for coinbase to
Begin TX.

3. Part of EIP-3860 (Limit and meter initcode): only add gas cost of
init code to Begin TX (missing gas cost changes in Create and OOG
Create).

Issue
privacy-scaling-explorations#1362

Local related PRs:
scroll-tech#497
scroll-tech#500
scroll-tech#507

Reference previous PR:
privacy-scaling-explorations#1361

- [x] Breaking change (fix or feature that would cause existing
functionality to not work as expected)

Unit test cases of CI could pass with Shanghai geth traces.

---------

Co-authored-by: Zhang Zhuo <[email protected]>
chokobole added a commit to kroma-network/zkevm-circuits that referenced this pull request Apr 18, 2024
@chokobole
feat: support EIP-3651(Warm coinbase) for Shanghai
c73e7af 
See scroll-tech/zkevm-circuits#500.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lispc lispc Awaiting requested review from lispc

Assignees
No one assigned
Labels
crate-bus-mapping crate-zkevm-circuits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silathdiir @lispc