feat: add shanghai feature and make CI pass with Shanghai geth traces
#1424
Conversation
github-actions
bot
added
crate-bus-mapping
silathdiir
changed the title
shanghai feature and support it in geth tracershanghai feature and support it in geth tracer
github-actions
bot
added
crate-eth-types
silathdiir
changed the title
shanghai feature and support it in geth tracershanghai feature and make CI pass with it
silathdiir
changed the title
shanghai feature and make CI pass with itshanghai feature and make CI pass with Shanghai geth traces
There was a problem hiding this comment.
The implementation looks good to me but I would like to discuss the feature approach.
So far we haven't introduced any rust feature to support new hard forks, we just implement the latest EIPs included. This PR introduces a feature so that the zkevm can be built with/without shanghai support. In which cases do we want to built without shanghai?
The code would look simpler without the rust feature, having shanghai implemented unconditionally. Could you give some thoughts on why implement this under a rust feature?
Yes. I see. I will delete related feature guard of When started to implement shanghai EIPs, we also supposed to upgrade After finishing shanghai EIPs, we upgraded testool and run for both shanghai and not-shanghai via this feature guard. And it seems to be not much different. with-shanghai ( |
…eature-and-support-in-geth-tracer
github-actions
bot
removed
the
crate-mock
|
Hi @ed255, I deleted the related code of |
|
This is ready to be merged once the branch is rebased against main. |
…eature-and-support-in-geth-tracer
silathdiir
deleted the
feat/add-shanghai-feature-and-support-in-geth-tracer
branch
…es (privacy-scaling-explorations#1424) 1. Add Shanghai related fields to chain config in geth-utils. 2. EIP-3651 (Warm COINBASE): add a new access-list write for coinbase to Begin TX. 3. Part of EIP-3860 (Limit and meter initcode): only add gas cost of init code to Begin TX (missing gas cost changes in Create and OOG Create). Issue privacy-scaling-explorations#1362 Local related PRs: scroll-tech#497 scroll-tech#500 scroll-tech#507 Reference previous PR: privacy-scaling-explorations#1361 - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) Unit test cases of CI could pass with Shanghai geth traces. --------- Co-authored-by: Zhang Zhuo <[email protected]>
…es (privacy-scaling-explorations#1424) 1. Add Shanghai related fields to chain config in geth-utils. 2. EIP-3651 (Warm COINBASE): add a new access-list write for coinbase to Begin TX. 3. Part of EIP-3860 (Limit and meter initcode): only add gas cost of init code to Begin TX (missing gas cost changes in Create and OOG Create). Issue privacy-scaling-explorations#1362 Local related PRs: scroll-tech#497 scroll-tech#500 scroll-tech#507 Reference previous PR: privacy-scaling-explorations#1361 - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) Unit test cases of CI could pass with Shanghai geth traces. --------- Co-authored-by: Zhang Zhuo <[email protected]>
…es (privacy-scaling-explorations#1424) 1. Add Shanghai related fields to chain config in geth-utils. 2. EIP-3651 (Warm COINBASE): add a new access-list write for coinbase to Begin TX. 3. Part of EIP-3860 (Limit and meter initcode): only add gas cost of init code to Begin TX (missing gas cost changes in Create and OOG Create). Issue privacy-scaling-explorations#1362 Local related PRs: scroll-tech#497 scroll-tech#500 scroll-tech#507 Reference previous PR: privacy-scaling-explorations#1361 - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) Unit test cases of CI could pass with Shanghai geth traces. --------- Co-authored-by: Zhang Zhuo <[email protected]>
…es (privacy-scaling-explorations#1424) 1. Add Shanghai related fields to chain config in geth-utils. 2. EIP-3651 (Warm COINBASE): add a new access-list write for coinbase to Begin TX. 3. Part of EIP-3860 (Limit and meter initcode): only add gas cost of init code to Begin TX (missing gas cost changes in Create and OOG Create). Issue privacy-scaling-explorations#1362 Local related PRs: scroll-tech#497 scroll-tech#500 scroll-tech#507 Reference previous PR: privacy-scaling-explorations#1361 - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) Unit test cases of CI could pass with Shanghai geth traces. --------- Co-authored-by: Zhang Zhuo <[email protected]>
Description
Add Shanghai related fields to chain config in geth-utils.
EIP-3651 (Warm COINBASE): add a new access-list write for coinbase to Begin TX.
Part of EIP-3860 (Limit and meter initcode): only add gas cost of init code to Begin TX (missing gas cost changes in Create and OOG Create).
Issue Link
Issue #1362
Local related PRs:
scroll-tech#497
scroll-tech#500
scroll-tech#507
Reference previous PR:
#1361
Type of change
How Has This Been Tested?
Unit test cases of CI could pass with Shanghai geth traces.