Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing a typo in readme.md #59

Closed
wants to merge 6 commits into from
Closed

Fixing a typo in readme.md #59

wants to merge 6 commits into from

Commits on Oct 3, 2024

  1. Improve file handling in convert_xcstrings_to_jsons.py 

    - Updated file reading to use a context manager for better resource management.
- Added error handling for FileNotFoundError when accessing Localizable.xcstrings.
    @OmarAI2003
    OmarAI2003 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    32b8f70 View commit details
    Browse the repository at this point in the history

  2. Add JSON loading error handling in convert_xcstrings_to_jsons.py 

    - Implement try-except block for JSONDecodeError to handle invalid JSON format.
    @OmarAI2003
    OmarAI2003 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    5b97d83 View commit details
    Browse the repository at this point in the history

  3. Refactor: Use context manager for writing JSON files to ensure proper… 

    … file handling.
    @OmarAI2003
    OmarAI2003 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    b1ccff7 View commit details
    Browse the repository at this point in the history

  4. Improve language handling and ensure directory creation 

    - Refined language handling.
- Added directory existence check and creation to prevent errors.
    @OmarAI2003
    OmarAI2003 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    42e76dd View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. made the changes as per the feedback and added Localizable.xcstrings… 

    … to 'jsons' directory
    @OmarAI2003
    OmarAI2003 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    0d48009 View commit details
    Browse the repository at this point in the history

  2. Fix typo in README: Changed 'an tools' to 'tools'

    @OmarAI2003
    OmarAI2003 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    4bfde02 View commit details
    Browse the repository at this point in the history