-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing a typo in readme.md #59
Conversation
- Updated file reading to use a context manager for better resource management. - Added error handling for FileNotFoundError when accessing Localizable.xcstrings.
- Implement try-except block for JSONDecodeError to handle invalid JSON format.
- Refined language handling. - Added directory existence check and creation to prevent errors.
… to 'jsons' directory
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and i18n rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
I’m closing this PR because it unintentionally includes commits from another branch . I created a new branch directly from |
I thought this had been merged, or was that in a downstream project, @OmarAI2003? |
We should do something with this here? |
No It was in another repo the Data repo |
Just saw the comment above. All good! |
Thanks for the explanation! |
This PR fixes a minor typo in the README.md file. I changed "an tools" to "tools".