Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow check for Windows builds #505

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Conversation

axif0
Copy link
Collaborator

@axif0 axif0 commented Nov 10, 2024

Contributor checklist


Description

In GitHub Actions, the default shell on Windows runners is PowerShell. However, activating a virtual environment in PowerShell can sometimes lead to execution policy issues. To simplify cross-platform compatibility, we can force the use of Bash on Windows runners, as GitHub Actions provides Git Bash on Windows.

Added condition for Homebrew setup which conditioned to run only on macOS.

Related issue

Copy link

github-actions bot commented Nov 10, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@axif0 axif0 changed the title Workflow for check for Windows builds Workflow check for Windows builds Nov 10, 2024
@andrewtavis andrewtavis self-requested a review November 10, 2024 12:53
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, @axif0! So happy that Windows is getting the support that it needs these days :) Thanks so much for your efforts in these regards 😊

@andrewtavis andrewtavis merged commit fe0b2aa into scribe-org:main Nov 10, 2024
9 checks passed
@andrewtavis andrewtavis mentioned this pull request Nov 10, 2024
2 tasks
@axif0 axif0 deleted the windowscheck branch November 25, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants