Merge pull request #505 from axif0/windowscheck

Workflow check for Windows builds
scribe-org · Nov 10, 2024 · fe0b2aa · fe0b2aa
2 parents f674d2f + b45f6ef
commit fe0b2aa
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/.github/workflows/python_package_ci.yaml b/.github/workflows/python_package_ci.yaml
@@ -14,11 +14,16 @@ jobs:
         os:
           - macos-latest
           - ubuntu-latest
+          - windows-latest
         python-version:
           - "3.9"
 
     runs-on: ${{ matrix.os }}
 
+    defaults:
+      run:
+        shell: bash
+
     steps:
       - uses: actions/checkout@v3
       - name: Set up Python ${{ matrix.python-version }}
@@ -28,13 +33,20 @@ jobs:
 
       - name: Create and Activate Virtual Environment
         run: |
-          python3 -m venv venv
-          source venv/bin/activate
+          if [ "$RUNNER_OS" == "Windows" ]; then
+            python -m venv venv
+            source venv/Scripts/activate
+          else
+            python3 -m venv venv
+            source venv/bin/activate
+          fi
 
       - name: Set up Homebrew
+        if: matrix.os == 'macos-latest'
         uses: Homebrew/actions/setup-homebrew@master
 
       - name: Install PyICU dependencies
+        if: matrix.os == 'macos-latest'
         run: |
           brew bundle install --file=Brewfile
           # configure PATH & PKG_CONFIG_PATH as per