Created and Added all the languages that support Emoji #440
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
|
@SethiShreya nice work |
| # Check if the language code exists in the dictionary | ||
| for code, name in languages.items(): | ||
| if name == language: | ||
| print(f"Emoji Generation for language : {language} is supported") |
There was a problem hiding this comment.
For lower and capitalization user input language, we need to dynamically handle it by language.lower()
| file_path=output_dir, | ||
| formatted_data=emoji_keywords_dict, | ||
| query_data_in_use=True, | ||
| language=language, |
There was a problem hiding this comment.
We should use language.capitalize(), therefore no No such file or directory: 'scribe_data_json_export/english/emoji_keywords.json' will cause. In file data-type should be '{user_given_directory}/English/emoji_keywords.json'
Then we can call scribe-data get -lang English -dt emoji_keywords -od ./output_data and get the file in output_data
|
cc: @mhmohona Can you please review in a new environment if you have free time in hand, as you got windows OS? Also, by applying the upper issues? |
There was a problem hiding this comment.
This is really really great, @SethiShreya :) I removed the JSON so we can base this directly off of the CLDR data as I think that's more sustainable. I'm getting the PyICU error for it not being installed as well, but I think we can close that with @axif0's PR or a combination of that one and your other one.
Signed off by Shreya Sethi
[email protected]
This PR addresses issue #397
@andrewtavis @Ekikereabasi-Nk please review it and give your feedback :)