-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centralized Emoji Keyword Functionality call for All Languages #397
Centralized Emoji Keyword Functionality call for All Languages #397
Conversation
Hey @KesharwaniArpita 👋 Just a quick note as I'll get back to this later: Please include a bit more code in commits than what you're doing now. You don't need to commit every single file change as this really makes the PR messy to look at. |
Sure! I'll take care of that. |
Hi @andrewtavis I have removed all the |
Can you also remove all emoji directories entirely, @KesharwaniArpita? So really get rid of all of the emoji files in each language directory :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, @KesharwaniArpita! I made these changes in another PR, but happy to squash this in :)
Contributor checklist
Description
This PR introduces a centralized function for generating emoji keywords across multiple languages. The shared functionality has been moved to a generalized function
generate_emoji_keyword()
in thescribe_data/unicode/generate_emoji_keyword.py
file by #379 , and individual language scripts have been refactored by me to call this centralized function. This allows for easier future updates and maintenance while still allowing language-specific customizations if needed.Refactored Language Scripts:
generate_emoji_keywords_en.py
,generate_emoji_keywords_fr.py
, etc.) to call the centralized function, passing the relevant parameters like language, file path, gender, and region.Flexible for Future Updates:
Languages Updated in This PR:
Remaining Work:
Review and feedback on the initial refactor is appreciated.
Related issue