Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ticksToRegeneration optional in Minerals #204

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Make ticksToRegeneration optional in Minerals #204

merged 1 commit into from
Oct 25, 2021

Conversation

matheusvellone
Copy link
Contributor

@matheusvellone matheusvellone commented Oct 22, 2021

Brief Description

Found that ticksToRegeneration on a Mineral is actually undefined when its amount is not 0
image
image

Prints from my rooms on shard3.
https://screeps.com/a/#!/room/shard3/E12N51
https://screeps.com/a/#!/room/shard3/E13N51

Checklists

  • Test passed
  • Coding style (indentation, etc)
  • Edits have been made to src/ files not index.d.ts
  • Run npm run dtslint to update index.d.ts

@pyrodogg
Copy link
Member

Thanks for the fix. It seems the game doesn't match the documentation. I'd suggest also submitting a PR to the screeps/docs repo, if one doesn't exist already.

Generally the patch number isn't change directly in individual PRs. It will be incremented when a batch of changes are pushed to DefinitelyTyped.

@matheusvellone
Copy link
Contributor Author

✅ Removed the package bump from PR

Also edited my description, because it is undefined when the amount is > 0.
Opened a PR on screeps/docs to update the docs also (thanks for the suggestion! 😄)

screeps/docs#184

@pyrodogg pyrodogg merged commit b2b476c into screepers:master Oct 25, 2021
pyrodogg added a commit that referenced this pull request Mar 27, 2022
Adds 204,205 to Unreleased section
Adds test for #205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants