Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dependencies] update 3rd party dependencies #407
base: master
Are you sure you want to change the base?
[dependencies] update 3rd party dependencies #407
Changes from 22 commits
9225f3a
05ed6c1
25a5446
f4a9ffc
450b73d
402dcf4
878a967
3dd95a7
9342d08
4df40f0
8df9044
81c3fc8
d6577e5
02489bf
0f4558f
8e316dd
02bc076
f4f98ba
109ee19
6e8caa9
616cdd7
8c4b490
911cd58
db8f39a
abf7150
7b83121
015be38
3213221
3811292
55e4131
d99ed0f
227cc64
b47afd0
fc441d4
c586b58
b3f158a
cddc023
cdeaef0
3c98c78
fddef8e
99f5670
b28c03f
962ac7f
e1482ac
22d0ad1
90886f3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use
tox
instead of usingflake8
directly, and keep this within thetox
configuration so that runningtox -e flake8
has the same effect, and users can run that locally?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github Actions were an experiment. We don't need them now, so I'll remove them.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It probably makes sense to remove this file in favor of
tox.ini
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed this on Slack.
requirements.txt
andrequirements-test.txt
serve to document the versions of the libraries that passed the tests when the branch was merged.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then we should either address this in code or limit the upper version of
click
to a version we support insetup.py
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. This test is complicated yet unimportant, so not enough reason to downgrade
click
.Also, there should be only minor changes on this release.
I'll leave this comment open to remind us to search or post an issue against
click
.